phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1976) Improve PhoenixDriver registration when addShutdownHook fails
Date Fri, 15 May 2015 18:29:02 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545941#comment-14545941
] 

Nick Dimiduk commented on PHOENIX-1976:
---------------------------------------

Tests are passing locally for me. Let's give BuildBot a chance to catch up. I'll commit either
on confirmation, or timeout.

> Improve PhoenixDriver registration when addShutdownHook fails
> -------------------------------------------------------------
>
>                 Key: PHOENIX-1976
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1976
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Josh Elser
>            Priority: Minor
>             Fix For: 4.5.0
>
>         Attachments: PHOENIX-1976-master.patch
>
>
> Noticed this in running some tests. RegionServer was shutting down and MetaDataRegionObserver
was just invoking {{postOpen}}
> When the {{Class.forName(PhoenixDriver.class.getName())}} gets called, the static initializer
in {{PhoenixDriver}} gets invoked. Because the RegionServer is already stopping, the {{addShutdownHook}}
fails with an {{IllegalArgumentException}}.
> It's not a _huge_ concern because we know the JVM is going down, but there are a few
things we could handle better:
> * Ensure the PhoenixDriver gets closed if the shutdown hook fails to register
> * Avoid registering the PhoenixDriver instance if we're shutting down



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message