Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
Date: Fri, 10 Apr 2015 19:41:12 +0000 (UTC)
From: "James Taylor (JIRA)" <jira@apache.org>
To: dev@phoenix.incubator.apache.org
Message-ID: <JIRA.12820172.1428694848000.57621.1428694872112@Atlassian.JIRA>
In-Reply-To: <JIRA.12820172.1428694848000@Atlassian.JIRA>
References: <JIRA.12820172.1428694848000@Atlassian.JIRA>
 <JIRA.12820172.1428694848265@arcas>
Subject: [jira] [Created] (PHOENIX-1835) Adjust MetaDataEndPointImpl
 timestamps if table is transactional
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

James Taylor created PHOENIX-1835:
-------------------------------------

             Summary: Adjust MetaDataEndPointImpl timestamps if table is transactional
                 Key: PHOENIX-1835
                 URL: https://issues.apache.org/jira/browse/PHOENIX-1835
             Project: Phoenix
          Issue Type: Sub-task
            Reporter: James Taylor
            Assignee: Thomas D'Silva


Phoenix correlates table metadata with the table data based on timestamp. Since Tephra is adjusting timestamps for the data, we need to do the same for the metadata operations (which aren't transactional through Tephra). Take a look at MetaDataEndPointImpl and the MetaDataMutationResult where we return the server timestamp (i.e. MetaDataMutationResult.getTable() for example). This timestamp should be run through the TransactionUtil.translateTimestamp() method).

Add a point-in-time test with a table being altered, but your connection being before that time (with CURRENT_SCN) as a test. We'll need to make sure the Puts to the SYSTEM.CATALOG get timestamped correctly (but I think the above will cause that).

Also, my other hack in PostDDLCompiler, should not be necessary after this:
{code}
                        // FIXME: DDL operations aren't transactional, so we're basing the timestamp on a server timestamp.
                        // Not sure what the fix should be. We don't need conflict detection nor filtering of invalid transactions
                        // in this case, so maybe this is ok.
                        if (tableRef.getTable().isTransactional()) {
                            ts = TransactionUtil.translateMillis(ts);
                        }
{code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)