Return-Path: X-Original-To: apmail-phoenix-dev-archive@minotaur.apache.org Delivered-To: apmail-phoenix-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EE94717614 for ; Sat, 11 Apr 2015 05:50:36 +0000 (UTC) Received: (qmail 39045 invoked by uid 500); 11 Apr 2015 05:50:36 -0000 Delivered-To: apmail-phoenix-dev-archive@phoenix.apache.org Received: (qmail 38784 invoked by uid 500); 11 Apr 2015 05:50:36 -0000 Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@phoenix.apache.org Delivered-To: mailing list dev@phoenix.apache.org Received: (qmail 38770 invoked by uid 99); 11 Apr 2015 05:50:36 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Apr 2015 05:50:36 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Sat, 11 Apr 2015 05:50:15 +0000 Received: (qmail 38704 invoked by uid 99); 11 Apr 2015 05:50:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Apr 2015 05:50:12 +0000 Date: Sat, 11 Apr 2015 05:50:12 +0000 (UTC) From: "James Taylor (JIRA)" To: dev@phoenix.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PHOENIX-1678) Detect client server jar mismatch/incomatibility by looking at the jar version stored in the MANIFEST file MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/PHOENIX-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490808#comment-14490808 ] James Taylor commented on PHOENIX-1678: --------------------------------------- [~ndimiduk] - seems like you may have done this in your QueryServer JIRA, no? > Detect client server jar mismatch/incomatibility by looking at the jar version stored in the MANIFEST file > ---------------------------------------------------------------------------------------------------------- > > Key: PHOENIX-1678 > URL: https://issues.apache.org/jira/browse/PHOENIX-1678 > Project: Phoenix > Issue Type: Bug > Reporter: Samarth Jain > Labels: Newbie > > Today, our way of detecting whether client and server jars are different is by comparing the static member variable values in MetadataProtocol.java. The check is hacky and could easily break once we start considering clusters upgraded to snapshot and "sunk" RC jars. The current mechanism is also prone to bugs when developers forget to change the member variable values even though they changed the underlying metadata. > If the jar names could be written to a MANIFEST file, then we can have a mechanism of detecting whether client and server jars belong to different versions or if they are incompatible. -- This message was sent by Atlassian JIRA (v6.3.4#6332)