phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maryann Xue (JIRA)" <>
Subject [jira] [Commented] (PHOENIX-1580) Support UNION ALL
Date Fri, 03 Apr 2015 19:13:56 GMT


Maryann Xue commented on PHOENIX-1580:

Catch with the specific Exception class instead of doing string comparison in the catch block.
I think I am saying the same thing as James is. Although, one of the tests throws SQLException
now since I removed one of your checks in the parser and it now reveals another problem which
throws SQLException. So, all you have to do is catch SQLFeatureNotSupportedException for testUnionAllinSubquery()
and catch SQLException for testUnionAllinSubqueryDerived(), and leave the catch block empty.

> Support UNION ALL
> -----------------
>                 Key: PHOENIX-1580
>                 URL:
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Alicia Ying Shu
>            Assignee: Alicia Ying Shu
>         Attachments: PHOENIX-1580-grammar.patch, Phoenix-1580-v1.patch, Phoenix-1580-v2.patch,
Phoenix-1580-v3.patch, Phoenix-1580-v4.patch, Phoenix-1580-v5.patch, Phoenix-1580-v6.patch,
Phoenix-1580-v7.patch, Phoenix-1580-v8.patch, phoenix-1580-v1-wipe.patch, phoenix-1580.patch,
> Select * from T1
> Select * from T2

This message was sent by Atlassian JIRA

View raw message