Return-Path: 
 <dev-return-13744-apmail-phoenix-dev-archive=phoenix.apache.org@phoenix.apache.org>
X-Original-To: apmail-phoenix-dev-archive@minotaur.apache.org
Delivered-To: apmail-phoenix-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 90F80175D2
	for <apmail-phoenix-dev-archive@minotaur.apache.org>;
 Wed, 18 Mar 2015 17:09:00 +0000 (UTC)
Received: (qmail 73481 invoked by uid 500); 18 Mar 2015 17:09:00 -0000
Delivered-To: apmail-phoenix-dev-archive@phoenix.apache.org
Received: (qmail 73365 invoked by uid 500); 18 Mar 2015 17:09:00 -0000
Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@phoenix.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@phoenix.apache.org>
List-Post: <mailto:dev@phoenix.apache.org>
List-Id: <dev.phoenix.apache.org>
Reply-To: dev@phoenix.apache.org
Delivered-To: mailing list dev@phoenix.apache.org
Received: (qmail 73349 invoked by uid 99); 18 Mar 2015 17:09:00 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Mar 2015 17:09:00 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Wed, 18 Mar 2015 17:08:59 +0000
Received: (qmail 72186 invoked by uid 99); 18 Mar 2015 17:08:39 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Mar 2015 17:08:39 +0000
Date: Wed, 18 Mar 2015 17:08:39 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@phoenix.incubator.apache.org
Message-ID: <JIRA.12743645.1411511948000.133232.1426698519221@Atlassian.JIRA>
In-Reply-To: <JIRA.12743645.1411511948000@Atlassian.JIRA>
References: <JIRA.12743645.1411511948000@Atlassian.JIRA>
 <JIRA.12743645.1411511948620@arcas>
Subject: [jira] [Commented] (PHOENIX-1287) Use the joni byte[] regex engine
 in place of j.u.regex
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/PHOENIX-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367475#comment-14367475 ] 

ASF GitHub Bot commented on PHOENIX-1287:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/46#discussion_r26684109
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/visitor/CloneExpressionVisitor.java ---
    @@ -107,7 +109,9 @@ public Expression visitLeave(ComparisonExpression node, List<Expression> l) {
     
         @Override
         public Expression visitLeave(LikeExpression node, List<Expression> l) {
    -        return Determinism.PER_INVOCATION.compareTo(node.getDeterminism()) > 0 ? node :  new LikeExpression(l);
    --- End diff --
    
    No instanceof checks. Add an abstract clone method to LikeExpression and call that here instead.
    
        abstract public LikeExpression clone(List<Expression> children);


> Use the joni byte[] regex engine in place of j.u.regex
> ------------------------------------------------------
>
>                 Key: PHOENIX-1287
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1287
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Shuxiong Ye
>              Labels: gsoc2015
>
> See HBASE-11907. We'd get a 2x perf benefit plus it's driven off of byte[] instead of strings.Thanks for the pointer, [~apurtell].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)