Return-Path: 
 <dev-return-13376-apmail-phoenix-dev-archive=phoenix.apache.org@phoenix.apache.org>
X-Original-To: apmail-phoenix-dev-archive@minotaur.apache.org
Delivered-To: apmail-phoenix-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 41FCD172C1
	for <apmail-phoenix-dev-archive@minotaur.apache.org>;
 Thu, 12 Mar 2015 20:22:15 +0000 (UTC)
Received: (qmail 12747 invoked by uid 500); 12 Mar 2015 20:22:15 -0000
Delivered-To: apmail-phoenix-dev-archive@phoenix.apache.org
Received: (qmail 12684 invoked by uid 500); 12 Mar 2015 20:22:15 -0000
Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@phoenix.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@phoenix.apache.org>
List-Post: <mailto:dev@phoenix.apache.org>
List-Id: <dev.phoenix.apache.org>
Reply-To: dev@phoenix.apache.org
Delivered-To: mailing list dev@phoenix.apache.org
Received: (qmail 12668 invoked by uid 99); 12 Mar 2015 20:22:14 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Mar 2015 20:22:14 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id B2C83E18FB; Thu, 12 Mar 2015 20:22:14 +0000 (UTC)
From: JamesRTaylor <git@git.apache.org>
To: dev@phoenix.apache.org
Reply-To: dev@phoenix.apache.org
References: <git-pr-45-phoenix@git.apache.org>
In-Reply-To: <git-pr-45-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request: PHOENIX-1715 Implement Build-in Math
 functio...
Content-Type: text/plain
Message-Id: <20150312202214.B2C83E18FB@git1-us-west.apache.org>
Date: Thu, 12 Mar 2015 20:22:14 +0000 (UTC)

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/45#discussion_r26340462
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/types/PWholeNumber.java ---
    @@ -0,0 +1,45 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.phoenix.schema.types;
    +
    +import org.apache.hadoop.hbase.io.ImmutableBytesWritable;
    +import org.apache.phoenix.schema.SortOrder;
    +
    +public abstract class PWholeNumber<T> extends PNumericType<T> {
    +
    +    protected PWholeNumber(String sqlTypeName, int sqlType, Class clazz,
    +            org.apache.phoenix.schema.types.PDataType.PDataCodec codec, int ordinal) {
    +        super(sqlTypeName, sqlType, clazz, codec, ordinal);
    +    }
    +
    +
    +    public final int signum(byte[] bytes, int offset, int length, SortOrder sortOrder) {
    --- End diff --
    
    These can be defined at PNumericType.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---