phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shuxiong <>
Subject [GitHub] phoenix pull request: PHOENIX-1715 Implement Build-in Math functio...
Date Tue, 10 Mar 2015 18:19:20 GMT
GitHub user shuxiong opened a pull request:

    PHOENIX-1715 Implement Build-in Math function sign

    1. Add Build-in Math Function Sign
    2. Add a new Type, PNumericType, which is superclass of all numeric type, such as PInteger,
PFloat etc.
        PNumericType has method getSign
       2.1 All integer types, PInteger, PLong etc., will compute sign result by checking the
content bytes.
       2.2 All float types, PFloat, PDouble etc, will construct objects and compare with zero,
for their complex content bytes.
    I mistakenly close last pull request, sorry for that.

You can merge this pull request into a Git repository by running:

    $ git pull 4.3-shuxiong-gsoc

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #45
commit 32089c5db6745aa710f579dcdae32b5fd2f03d51
Author: yesx <>
Date:   2015-03-09T18:13:39Z

    PHOENIX-1715 Implement Build-in Math function sign

commit 21f7aafd10fc3b6052fe14859918f3649b6b6de2
Author: yesx <>
Date:   2015-03-10T15:28:59Z

    PHOENIX-1715 add PNumericType, being all Integer DataType superclass

commit 4abe9c225754f1993eccb45094042c9e79016db6
Author: yesx <>
Date:   2015-03-10T18:05:10Z

    PHOENIX-1715 add PNumericType, being all Float DataType superclass

commit 92c7a3a869e22baf24a5a615bde69fca80698e6d
Author: yesx <>
Date:   2015-03-10T18:18:59Z

    code refinement


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message