phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1731) Add getNextIndexedKey() to IndexHalfStoreFileReader and FilteredKeyValueScanner
Date Fri, 13 Mar 2015 02:17:38 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359805#comment-14359805
] 

Lars Hofhansl commented on PHOENIX-1731:
----------------------------------------

Looking forward, let's also work out how we can avoid this in the future. Maybe in HBase 1.1
we can add super classes for these typed of classes in order to allow default implementations
(as suggested by [~giacomotaylor] on HBASE-13109).

> Add getNextIndexedKey() to IndexHalfStoreFileReader and FilteredKeyValueScanner
> -------------------------------------------------------------------------------
>
>                 Key: PHOENIX-1731
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1731
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 5.0.0, 4.2.3, 4.3.1
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>         Attachments: 1731.txt
>
>
> See HBASE-13109, which changes two private interfaces, which breaks Phoenix compilation,
which uses these interfaces.
> On the jira we decided not to remove those changes (that's why they're marked private).
> But, we can easily fix this in Phoenix by adding these methods to the classes that cause
the problem, being care not to add the override annotation. The method can safely return null,
in which case the optimization will not be used when these classes are used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message