phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1715) Implement Build-in math function Sign
Date Thu, 12 Mar 2015 20:21:39 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359315#comment-14359315
] 

ASF GitHub Bot commented on PHOENIX-1715:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/45#discussion_r26340384
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/types/PUnsignedWholeNumber.java
---
    @@ -0,0 +1,39 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.phoenix.schema.types;
    +
    +import org.apache.phoenix.schema.SortOrder;
    +
    +public abstract class PUnsignedWholeNumber<T> extends PWholeNumber<T> {
    +
    +    protected PUnsignedWholeNumber(String sqlTypeName, int sqlType, Class clazz,
    +            org.apache.phoenix.schema.types.PDataType.PDataCodec codec, int ordinal)
{
    +        super(sqlTypeName, sqlType, clazz, codec, ordinal);
    +    }
    +
    +    @Override
    --- End diff --
    
    unnecessary


> Implement Build-in math function Sign
> -------------------------------------
>
>                 Key: PHOENIX-1715
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1715
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Shuxiong Ye
>            Assignee: Shuxiong Ye
>
> Take a look at the typical math functions that are implemented in relational database
systems (http://www.postgresql.org/docs/current/static/functions-math.html) and implement
the same for Phoenix in Java following this guide: http://phoenix-hbase.blogspot.com/2013/04/how-to-add-your-own-built-in-function.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message