phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Taylor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1705) implement ARRAY_APPEND built in function
Date Mon, 09 Mar 2015 03:46:38 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352496#comment-14352496
] 

James Taylor commented on PHOENIX-1705:
---------------------------------------

Good point about ARRAY_CAT, [~Dumindux]. Although it work for now (b/c we don't support multi-dimensional
arrays), if we do down the road, it'd be ambiguous. Let's flag that case as an error then.

Yes, correct - do as much checking as you can in the constructor. It's called *once* during
compilation versus *once per row* for evaluate. For example, with the following:
{code}
SELECT ARRAY_APPEND(array_col, 1) FROM T;
{code}
assume that array_col is an INTEGER ARRAY, so this is valid, and assume T has 1B rows. You'd
be doing the type validation 1B times instead of 1 time if you do type checking in the evaluate
versus the constructor.

> implement ARRAY_APPEND built in function
> ----------------------------------------
>
>                 Key: PHOENIX-1705
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1705
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Dumindu Buddhika
>            Assignee: Dumindu Buddhika
>         Attachments: PHOENIX-1705_implement_ARRAY_APPEND_built_in_function.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message