phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "rajeshbabu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1691) Allow settting sampling rate while enabling tracing.
Date Tue, 17 Mar 2015 19:34:38 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14365874#comment-14365874
] 

rajeshbabu commented on PHOENIX-1691:
-------------------------------------

I will upload patch addressing the comments.

bq. A general question, can you help me understand the reason behind closing the existing
trace scope whenever there is a change in the sampler type? Would it be ok to just carry on
with the existing trace scope for cases when you are switching from ALWAYS to PROBABILITY
and vice-versa?
I didn't have specific reason for this. I think its better to carry on with the existing scope.
Will change it as well.

> Allow settting sampling rate while enabling tracing.
> ----------------------------------------------------
>
>                 Key: PHOENIX-1691
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1691
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>             Fix For: 5.0.0, 4.4
>
>         Attachments: PHOENIX-1691.patch, PHOENIX-1691_v2.patch
>
>
> Now we can dynamically enable/disable tracing from query. We should also be able to set
sampling rate while enabling tracing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message