phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alicia Ying Shu (JIRA)" <>
Subject [jira] [Comment Edited] (PHOENIX-1580) Support UNION ALL
Date Wed, 25 Mar 2015 23:41:53 GMT


Alicia Ying Shu edited comment on PHOENIX-1580 at 3/25/15 11:40 PM:

Modified the grammar as pointed out. I moved ORDER BY and LIMIT to hinted_select_node. However,
hinted_select_node has to refer to hinted_set_select_node, but not through using select_node.
There are many more tests failing than before I made the modifications. Parameter count is
one thing. Checking aggregate and sequence are other issues related to context which could
be wrong too. This can potentially un-stablize Phoenix. The grammar change is not critical
for UNION ALL. I would request use Jira-1758 to track the grammar changes when we have better
thought of the consequences of grammar changes and what it really gains. Thanks. [~jamestaylor]

was (Author: aliciashu):
Modified the grammar as pointed out. Fixing existing tests.

> Support UNION ALL
> -----------------
>                 Key: PHOENIX-1580
>                 URL:
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Alicia Ying Shu
>            Assignee: Alicia Ying Shu
>         Attachments: phoenix-1580-v1-wipe.patch, phoenix-1580.patch, unionall-wipe.patch
> Select * from T1
> Select * from T2

This message was sent by Atlassian JIRA

View raw message