phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maryann Xue (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1580) Support UNION ALL
Date Mon, 16 Mar 2015 19:43:40 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14363772#comment-14363772
] 

Maryann Xue commented on PHOENIX-1580:
--------------------------------------

Thanks a lot for the review, [~jamestaylor]! 
Good work, [~ayingshu]! After using compileSubquery(), the code in QueryCompiler looks even
clearer now. And thus it would not be necessary to make changes in PhoenixStatement, as [~jamestaylor]
pointed out. The normalization or other rewrite stuff would all be done by compileSubquery().
Add one more comment here: why would we need method setPlans()? Can't we just create new UnionAllPlan
if necessary?
{code}
+
+	public void setPlans(List<QueryPlan> plans) {
+		this.plans = plans;
+	}
{code}


> Support UNION ALL
> -----------------
>
>                 Key: PHOENIX-1580
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1580
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Alicia Ying Shu
>            Assignee: Alicia Ying Shu
>         Attachments: phoenix-1580.patch, unionall-wipe.patch
>
>
> Select * from T1
> UNION ALL
> Select * from T2



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message