phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shuxiong <...@git.apache.org>
Subject [GitHub] phoenix pull request: Draft for PHOENIX-1287 subtask, ByteBasedLik...
Date Wed, 18 Mar 2015 15:17:42 GMT
Github user shuxiong commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/46#discussion_r26672350
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/expression/util/regex/JavaRegexWrapper.java
---
    @@ -0,0 +1,89 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.phoenix.expression.util.regex;
    +
    +import java.util.regex.Matcher;
    +import java.util.regex.Pattern;
    +
    +import org.apache.hadoop.hbase.io.ImmutableBytesWritable;
    +import org.apache.phoenix.schema.SortOrder;
    +
    +import com.google.common.base.Preconditions;
    +
    +public class JavaRegexWrapper {
    +    static class JavaPattern extends AbstractBasePattern {
    +
    +        private final Pattern pattern;
    +        private boolean isLastMatcherStringNull;
    +
    +        JavaPattern(String patternString) {
    +            this(patternString, 0);
    +        }
    +
    +        JavaPattern(String patternString, int flags) {
    +            if (patternString != null) {
    +                pattern = Pattern.compile(patternString, flags);
    +            } else {
    +                pattern = null;
    +            }
    +            isLastMatcherStringNull = false;
    +        }
    +
    +        @Override
    +        public AbstractBaseMatcher macher(ImmutableBytesWritable ptr, SortOrder sortOrder)
{
    +            Preconditions.checkNotNull(ptr);
    +            Preconditions.checkNotNull(sortOrder);
    +            String matcherSourceStr = Utils.immutableBytesWritableToString(ptr, sortOrder);
    +            if (matcherSourceStr == null) {
    +                isLastMatcherStringNull = true;
    +                return null;
    +            }
    +            isLastMatcherStringNull = false;
    +            return new JavaMatcher(pattern.matcher(matcherSourceStr));
    +        }
    +
    +        @Override
    +        public boolean isPatternStringNull() {
    --- End diff --
    
    1. isPatternStringNull seems to be useless. I will remove it later.
    2. isMatcherSourceStrNull is necessary, Because function matcher of AbstractBasePattern
takes ImmutableBytesWritable as arguments, and we don't know if the parameters are null in
LikeExpression, until we turn the arguments to Bytes or Strings in the regex engine(the JONI
one and the Java one) in BytesBased or StringsBased LikeExpression.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message