Mailing-List: contact dev-help@phoenix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@phoenix.apache.org
From: twdsilva <git@git.apache.org>
To: dev@phoenix.apache.org
Reply-To: dev@phoenix.apache.org
References: <git-pr-36-phoenix@git.apache.org>
In-Reply-To: <git-pr-36-phoenix@git.apache.org>
Subject: [GitHub] phoenix pull request: PHOENIX-1639 Enhance
 function/expression ind...
Content-Type: text/plain
Message-Id: <20150214005028.E61C4E07EC@git1-us-west.apache.org>
Date: Sat, 14 Feb 2015 00:50:28 +0000 (UTC)

Github user twdsilva commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/36#discussion_r24709209
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
    @@ -435,6 +435,9 @@ private boolean addIndexesFromPhysicalTable(MetaDataMutationResult result) throw
                     boolean containsAllReqdCols = true;
                     // Ensure that all indexed columns from index on physical table
                     // exist in the view too (since view columns may be removed)
    +                // TODO 
    --- End diff --
    
    When the col represents an expression, how should this be handled?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---