phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1639) Enhance function/expression index tests
Date Tue, 17 Feb 2015 17:55:11 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324557#comment-14324557
] 

ASF GitHub Bot commented on PHOENIX-1639:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/36#discussion_r24836686
  
    --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexExpressionIT.java
---
    @@ -123,7 +126,7 @@ protected void helpTestCreateAndUpdate(boolean mutable, boolean localIndex)
thro
                         + (localIndex ? "LOCAL" : "")
                         + " INDEX IDX ON "
                         + fullDataTableName
    -                    + " ((UPPER(varchar_pk) || '_' || UPPER(char_pk) || '_' || UPPER(varchar_col1)
|| '_' || UPPER(char_col2)),"
    +                    + " ((UPPER(varchar_pk) || '_' || UPPER(char_pk) || '_' || UPPER(varchar_col1)
|| '_' || UPPER(b.char_col2)),"
    --- End diff --
    
    Just curious about the prefixing of the column name with "b". Was that required, or were
you just testing that this wouldn't be a problem?


> Enhance function/expression index tests
> ---------------------------------------
>
>                 Key: PHOENIX-1639
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1639
>             Project: Phoenix
>          Issue Type: Test
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>
> Add tests for views, negative scenarios, sort order of expression. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message