phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabriel Reid (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1543) AutoCommit should be turned on by default on new connections
Date Fri, 19 Dec 2014 07:51:13 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14253112#comment-14253112
] 

Gabriel Reid commented on PHOENIX-1543:
---------------------------------------

This is easy to fix (and will mean that a lot of {{setAutoCommit(true)}} statements can be
removed in integration tests), but it could be a bit of a backwards-compatibility issue for
some users. On the other hand, I think a lot of SQL editors call {{Connection.setAutoCommit(true)}}
on connections anyhow.

I'll take care of fixing this, but I'd just like to get some feedback first on where we want
to do this (i.e. do we want to change this for the 4.3 release)?

> AutoCommit should be turned on by default on new connections
> ------------------------------------------------------------
>
>                 Key: PHOENIX-1543
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1543
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Gabriel Reid
>
> According to the javadoc for [Connection|https://docs.oracle.com/javase/7/docs/api/java/sql/Connection.html],
and also for [Connection.setAutoCommit|https://docs.oracle.com/javase/7/docs/api/java/sql/Connection.html#setAutoCommit(boolean)],
auto-commit should be turned on by default on new connections. Taken from the javadoc:
> {quote}
> By default a Connection object is in auto-commit mode, which means that it automatically
commits changes after executing each statement.
> {quote}
> Phoenix currently sets auto-commit to false by default on new connections.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message