phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alicia Ying Shu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PHOENIX-1409) Allow ALTER TABLE <table> SET command to update HTableDescriptor and HColumnDescriptor properties
Date Sat, 20 Dec 2014 00:39:14 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14254359#comment-14254359
] 

Alicia Ying Shu commented on PHOENIX-1409:
------------------------------------------

[~giacomotaylor] > Why is this new check here? It's ok to add a new column family in an
add column call.
For your question above, I mentioned it in TTL (phoenix-1240) discussion below:

ALTER TABLE T1 SET CF.TTL=86400;

The ALTER TABLE sql would throw exception because "CF" is not defined. "SET" is only set property.
We should only add new column family through ALTER TABLE ADD (column). The added check is
checking "SET" property. The data structure "columnFamilyProps" contains only "set" properties
. If adding a new column family in an add column call, it will not be invoked.

ALTER TABLE T1 add cf.col1;

> Allow ALTER TABLE <table> SET command to update HTableDescriptor and HColumnDescriptor
properties
> -------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-1409
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1409
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.2
>            Reporter: James Taylor
>            Assignee: Alicia Ying Shu
>         Attachments: Phoenix-1409-v1.patch, Phoenix-1409.patch, WIP.patch
>
>
> Once PHOENIX-1408 is fixed, we should allow HTableDescriptor and HColumnDescriptor properties
through the ALTER TABLE <table> SET command. It'd just be a matter of passing these
properties through the existing methods, as we support this for CREATE TABLE.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message