phoenix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alicia Ying Shu (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (PHOENIX-1409) Allow ALTER TABLE <table> SET command to update HTableDescriptor and HColumnDescriptor properties
Date Wed, 31 Dec 2014 08:51:13 GMT

    [ https://issues.apache.org/jira/browse/PHOENIX-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262020#comment-14262020
] 

Alicia Ying Shu edited comment on PHOENIX-1409 at 12/31/14 8:50 AM:
--------------------------------------------------------------------

[~jamestaylor], [~samarth.jain@gmail.com], attached is the updated patch that addressed the
following issues:

1) Thanks Samarth Jain for suggested changes in Phoenix-1409-v3.patch. However there is a
regression on setting TTL for default column family. Fixed that and added a test case. 
2) For the new modifyTable API in ConnectionQueryServices, removed HBaseAdmin as an argument.
3) Method modifyTableProps now returns the HTableDescriptor. So no need to get the HTableDescriptor
again for setTTLForNewColumnFamilies if it is available.
4) For the new Property class, define the PropertyValidator.validate as: void validate(TableProperty
property, boolean isMutating, PTableType tableType) throws SQLException;
5) Moved the check for not setting column family property as table property outside of the
validate to error out sooner. 
6) Reverted unrelated test changes.




was (Author: aliciashu):
[~jamestaylor], [~samarth.jain@gmail.com], attached is the updated patch that addressed the
following issues:

1) Thanks Samarth Jain for suggested changes in Phoenix-1409-v3.patch. However there is a
regression on setting TTL for default column family. Fixed that and added a test case. 
2) For the new modifyTable API in ConnectionQueryServices, removed HBaseAdmin as an argument.
3) Method modifyTableProps now returns the HTableDescriptor. So no need to get the HTableDescriptor
again for setTTLForNewColumnFamilies if it is available.
4) For the new Property class, define the PropertyValidator.validate as: void validate(TableProperty
property, boolean isMutating, PTableType tableType) throws SQLException;
5) Moved the check for not setting column family property as table property outside of the
validate call as suggested so as to error out sooner. 
6) Reverted unrelated test changes.



> Allow ALTER TABLE <table> SET command to update HTableDescriptor and HColumnDescriptor
properties
> -------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-1409
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1409
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.2
>            Reporter: James Taylor
>            Assignee: Alicia Ying Shu
>         Attachments: PHOENIX-1409-v3.patch, Phoenix-1409-v1.patch, Phoenix-1409-v4.patch,
Phoenix-1409.patch, WIP.patch, phoenix-1409-v2.patch
>
>
> Once PHOENIX-1408 is fixed, we should allow HTableDescriptor and HColumnDescriptor properties
through the ALTER TABLE <table> SET command. It'd just be a matter of passing these
properties through the existing methods, as we support this for CREATE TABLE.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message