phoenix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From els...@apache.org
Subject [3/8] phoenix git commit: PHOENIX-3136 Do not relocate org.apache.calcite in queryserver/thin-client
Date Tue, 02 Aug 2016 23:25:29 GMT
PHOENIX-3136 Do not relocate org.apache.calcite in queryserver/thin-client

Relocation of these classes breaks compatibility with previous versions
of Phoenix.


Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo
Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/39cebc2c
Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/39cebc2c
Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/39cebc2c

Branch: refs/heads/4.x-HBase-1.0
Commit: 39cebc2caf2232be907056c36ae32e27dfad7bec
Parents: af4fb44
Author: Josh Elser <elserj@apache.org>
Authored: Tue Aug 2 11:51:37 2016 -0400
Committer: Josh Elser <elserj@apache.org>
Committed: Tue Aug 2 19:04:02 2016 -0400

----------------------------------------------------------------------
 phoenix-queryserver-client/pom.xml | 7 +++----
 phoenix-queryserver/pom.xml        | 7 +++----
 2 files changed, 6 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/phoenix/blob/39cebc2c/phoenix-queryserver-client/pom.xml
----------------------------------------------------------------------
diff --git a/phoenix-queryserver-client/pom.xml b/phoenix-queryserver-client/pom.xml
index d64cc3e..c2e8920 100644
--- a/phoenix-queryserver-client/pom.xml
+++ b/phoenix-queryserver-client/pom.xml
@@ -113,10 +113,9 @@
                   <shadedPattern>${shaded.package}.com.fasterxml</shadedPattern>
                 </relocation>
                 <!-- ORG relocation -->
-                <relocation>
-                  <pattern>org.apache.calcite</pattern>
-                  <shadedPattern>${shaded.package}.org.apache.calcite</shadedPattern>
-                </relocation>
+                <!-- Calcite/Avatica is not relocated because the wire API (as of <=1.8.0)
expects
+                     consistent class names on client and server. Relocating these would
break
+                     backwards compatibility. -->
                 <relocation>
                   <pattern>org.apache.commons</pattern>
                   <shadedPattern>${shaded.package}.org.apache.commons</shadedPattern>

http://git-wip-us.apache.org/repos/asf/phoenix/blob/39cebc2c/phoenix-queryserver/pom.xml
----------------------------------------------------------------------
diff --git a/phoenix-queryserver/pom.xml b/phoenix-queryserver/pom.xml
index 599ed7d..441c6d5 100644
--- a/phoenix-queryserver/pom.xml
+++ b/phoenix-queryserver/pom.xml
@@ -105,10 +105,9 @@
                   <pattern>org.eclipse.jetty</pattern>
                   <shadedPattern>${shaded.package}.org.eclipse.jetty</shadedPattern>
                 </relocation>
-                <relocation>
-                  <pattern>org.apache.calcite</pattern>
-                  <shadedPattern>${shaded.package}.org.apache.calcite</shadedPattern>
-                </relocation>
+                <!-- Calcite/Avatica is not relocated because the wire API (as of <=1.8.0)
expects
+                     consistent class names on client and server. Relocating these would
break
+                     backwards compatibility. -->
               </relocations>
             </configuration>
           </execution>


Mime
View raw message