phoenix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jamestay...@apache.org
Subject phoenix git commit: PHOENIX-2616 Indexes over immutable tables not marked as immutable
Date Thu, 21 Jan 2016 05:44:26 GMT
Repository: phoenix
Updated Branches:
  refs/heads/4.x-HBase-0.98 2a8d9e7b1 -> 6d3a5f238


PHOENIX-2616 Indexes over immutable tables not marked as immutable


Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo
Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/6d3a5f23
Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/6d3a5f23
Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/6d3a5f23

Branch: refs/heads/4.x-HBase-0.98
Commit: 6d3a5f238723a887964f93f34e7ed32e39d78a9b
Parents: 2a8d9e7
Author: James Taylor <jtaylor@salesforce.com>
Authored: Wed Jan 20 21:40:00 2016 -0800
Committer: James Taylor <jtaylor@salesforce.com>
Committed: Wed Jan 20 21:43:07 2016 -0800

----------------------------------------------------------------------
 .../phoenix/query/ConnectionQueryServicesImpl.java  | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/phoenix/blob/6d3a5f23/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
----------------------------------------------------------------------
diff --git a/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
b/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
index cf75c42..afcd7cd 100644
--- a/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
+++ b/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
@@ -188,12 +188,6 @@ import org.apache.twill.zookeeper.ZKClients;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import co.cask.tephra.TransactionSystemClient;
-import co.cask.tephra.TxConstants;
-import co.cask.tephra.distributed.PooledClientProvider;
-import co.cask.tephra.distributed.TransactionServiceClient;
-import co.cask.tephra.hbase98.coprocessor.TransactionProcessor;
-
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.Joiner;
 import com.google.common.base.Throwables;
@@ -206,6 +200,12 @@ import com.google.common.collect.Maps;
 import com.google.common.collect.Sets;
 import com.google.common.util.concurrent.ThreadFactoryBuilder;
 
+import co.cask.tephra.TransactionSystemClient;
+import co.cask.tephra.TxConstants;
+import co.cask.tephra.distributed.PooledClientProvider;
+import co.cask.tephra.distributed.TransactionServiceClient;
+import co.cask.tephra.hbase98.coprocessor.TransactionProcessor;
+
 public class ConnectionQueryServicesImpl extends DelegateQueryServices implements ConnectionQueryServices
{
     private static final Logger logger = LoggerFactory.getLogger(ConnectionQueryServicesImpl.class);
     private static final int INITIAL_CHILD_SERVICES_CAPACITY = 100;
@@ -2258,6 +2258,8 @@ public class ConnectionQueryServicesImpl extends DelegateQueryServices
implement
         SQLException sqlE = null;
         try {
             metaConnection.createStatement().executeUpdate("ALTER TABLE " + tableName + "
ADD " + (addIfNotExists ? " IF NOT EXISTS " : "") + columns );
+        } catch (NewerTableAlreadyExistsException e) {
+            logger.warn("Table already modified at this timestamp, so assuming add of these
columns already done: " + columns);
         } catch (SQLException e) {
             logger.warn("Add column failed due to:" + e);
             sqlE = e;
@@ -2565,7 +2567,7 @@ public class ConnectionQueryServicesImpl extends DelegateQueryServices
implement
                     ")\n" + 
                     "WHERE A.COLUMN_FAMILY IS NULL AND\n" + 
                     " B.COLUMN_FAMILY IS NOT NULL AND\n" + 
-                    " A.IMMUTABLE_ROWS = TRUE;");
+                    " A.IMMUTABLE_ROWS = TRUE");
         } finally {
             metaConnection.setAutoCommit(autoCommit);
         }


Mime
View raw message