phoenix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jamestay...@apache.org
Subject [1/2] phoenix git commit: PHOENIX-2616 Indexes over immutable tables not marked as immutable
Date Thu, 21 Jan 2016 05:13:18 GMT
Repository: phoenix
Updated Branches:
  refs/heads/4.x-HBase-0.98 2f8a27eae -> 2a8d9e7b1


PHOENIX-2616 Indexes over immutable tables not marked as immutable


Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo
Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/29c66327
Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/29c66327
Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/29c66327

Branch: refs/heads/4.x-HBase-0.98
Commit: 29c6632744c931c8b21b22316b745b0ac5ab4b53
Parents: 2f8a27e
Author: James Taylor <jtaylor@salesforce.com>
Authored: Wed Jan 20 21:04:03 2016 -0800
Committer: James Taylor <jtaylor@salesforce.com>
Committed: Wed Jan 20 21:11:21 2016 -0800

----------------------------------------------------------------------
 .../src/it/java/org/apache/phoenix/end2end/index/IndexIT.java    | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/phoenix/blob/29c66327/phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexIT.java
----------------------------------------------------------------------
diff --git a/phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexIT.java b/phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexIT.java
index e369dae..6d54076 100644
--- a/phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexIT.java
+++ b/phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexIT.java
@@ -70,6 +70,7 @@ public class IndexIT extends BaseHBaseManagedTimeIT {
 	
 	private final boolean localIndex;
     private final boolean transactional;
+    private final boolean mutable;
 	private final String tableDDLOptions;
 	private final String tableName;
     private final String indexName;
@@ -79,6 +80,7 @@ public class IndexIT extends BaseHBaseManagedTimeIT {
 	public IndexIT(boolean localIndex, boolean mutable, boolean transactional) {
 		this.localIndex = localIndex;
 		this.transactional = transactional;
+		this.mutable = mutable;
 		StringBuilder optionBuilder = new StringBuilder();
 		if (!mutable) 
 			optionBuilder.append(" IMMUTABLE_ROWS=true ");
@@ -461,7 +463,7 @@ public class IndexIT extends BaseHBaseManagedTimeIT {
 	        // Can't set IMMUTABLE_ROWS, MULTI_TENANT or DEFAULT_COLUMN_FAMILY_NAME on an index
 	        assertNull(indexTable.getDefaultFamilyName());
 	        assertFalse(indexTable.isMultiTenant());
-	        assertFalse(indexTable.isImmutableRows());
+	        assertEquals(mutable, !indexTable.isImmutableRows()); // Should match table
 	        if(localIndex) {
 	            assertEquals(10, indexTable.getBucketNum().intValue());
 	            assertTrue(indexTable.isWALDisabled());


Mime
View raw message