phoenix-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jamestay...@apache.org
Subject phoenix git commit: PHOENIX-1958 Minimize memory allocation on new connection
Date Sun, 10 May 2015 01:17:22 GMT
Repository: phoenix
Updated Branches:
  refs/heads/4.3 5317385ec -> 52d183356


PHOENIX-1958 Minimize memory allocation on new connection


Project: http://git-wip-us.apache.org/repos/asf/phoenix/repo
Commit: http://git-wip-us.apache.org/repos/asf/phoenix/commit/52d18335
Tree: http://git-wip-us.apache.org/repos/asf/phoenix/tree/52d18335
Diff: http://git-wip-us.apache.org/repos/asf/phoenix/diff/52d18335

Branch: refs/heads/4.3
Commit: 52d18335656bd5991a6107447fb2414804fd4bb8
Parents: 5317385
Author: James Taylor <jtaylor@salesforce.com>
Authored: Sat May 9 18:13:49 2015 -0700
Committer: James Taylor <jtaylor@salesforce.com>
Committed: Sat May 9 18:16:41 2015 -0700

----------------------------------------------------------------------
 .../src/main/java/org/apache/phoenix/util/ReadOnlyProps.java    | 5 +++++
 1 file changed, 5 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/phoenix/blob/52d18335/phoenix-core/src/main/java/org/apache/phoenix/util/ReadOnlyProps.java
----------------------------------------------------------------------
diff --git a/phoenix-core/src/main/java/org/apache/phoenix/util/ReadOnlyProps.java b/phoenix-core/src/main/java/org/apache/phoenix/util/ReadOnlyProps.java
index 47137ef..a6fb7a5 100644
--- a/phoenix-core/src/main/java/org/apache/phoenix/util/ReadOnlyProps.java
+++ b/phoenix-core/src/main/java/org/apache/phoenix/util/ReadOnlyProps.java
@@ -27,6 +27,9 @@ import java.util.Properties;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import com.google.common.base.Objects;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.Maps;
@@ -40,6 +43,7 @@ import com.google.common.collect.Maps;
  * @since 1.2.2
  */
 public class ReadOnlyProps implements Iterable<Entry<String, String>> {
+    private static final Logger logger = LoggerFactory.getLogger(ReadOnlyProps.class);
     public static final ReadOnlyProps EMPTY_PROPS = new ReadOnlyProps();
     private final Map<String, String> props;
     
@@ -296,6 +300,7 @@ public class ReadOnlyProps implements Iterable<Entry<String, String>>
{
             String value = entry.getValue().toString();
             String oldValue = props.get(key);
             if (!Objects.equal(oldValue, value)) {
+                if (logger.isDebugEnabled()) logger.debug("Creating new ReadOnlyProps due
to " + key + " with " + oldValue + "!=" + value);
                 return new ReadOnlyProps(this, overrides);
             }
         }


Mime
View raw message