perl-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Torsten Förtsch <torsten.foert...@gmx.net>
Subject Re: Fwd: svn commit: r987890 - in /perl/Apache-Test/trunk: Changes lib/Apache/TestConfigPerl.pm
Date Sun, 22 Aug 2010 19:25:39 GMT
On Sunday, August 22, 2010 20:02:05 Fred Moyer wrote:
> I put out a release candidate for Apache-Test 1.33 yesterday.  Did you
> see the email come through?  An archive copy of it is located here:
> 
> http://www.gossamer-threads.com/lists/modperl/dev/101934
> 
> This commit puts us in a weird place; I can't really go forward with
> testing the release candidate with features being added after it was
> rolled like this was.

Oops, I missed that, sorry! Now, that you mention it I recall having seen 
something.

However, I think that change should go to the release. It fixes a bug that can 
cause errors that are difficult to trace.

Suppose a RPM/debian package provider builds a package for a mod_perl based 
module. He'll probably set APACHE_TEST_NO_STICKY_PREFERENCES to prevent 
~/.apache-test/... to be written. Now, the module contains a 
t/TESTlib/something or so that uses Apache::Test itself. AT then is not aware 
of APACHE_TEST_NO_STICKY_PREFERENCES and tries to save the config. This may 
write ~/.apache-test/Apache/TestConfigData.pm or, worse, it may place 
Apache/TestConfigData.pm somewhere in @INC in the package being built. This 
may get through unnoticed and in the end the package contains a config that 
does not match the system.

So, had I noticed I'd given you a -1 anyway.

Torsten Förtsch

-- 
Need professional modperl support? Hire me! (http://foertsch.name)

Like fantasy? http://kabatinte.net

Mime
View raw message