perl-test-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kbr...@apache.org
Subject svn commit: r1544955 - /perl/Apache-Test/trunk/lib/Apache/TestSSLCA.pm
Date Sun, 24 Nov 2013 10:57:33 GMT
Author: kbrand
Date: Sun Nov 24 10:57:32 2013
New Revision: 1544955

URL: http://svn.apache.org/r1544955
Log:
Perl 5.17.10 or later now refuses to compile this (improper) construct with
"Use of each() on hash after insertion without resetting hash iterator
results in undefined behavior" (severe internal warning, enabled by default)

Modified:
    perl/Apache-Test/trunk/lib/Apache/TestSSLCA.pm

Modified: perl/Apache-Test/trunk/lib/Apache/TestSSLCA.pm
URL: http://svn.apache.org/viewvc/perl/Apache-Test/trunk/lib/Apache/TestSSLCA.pm?rev=1544955&r1=1544954&r2=1544955&view=diff
==============================================================================
--- perl/Apache-Test/trunk/lib/Apache/TestSSLCA.pm (original)
+++ perl/Apache-Test/trunk/lib/Apache/TestSSLCA.pm Sun Nov 24 10:57:32 2013
@@ -100,8 +100,9 @@ my $cert_dn = {
 };
 
 #generate DSA versions of the server certs/keys
-while (my($key, $val) = each %$cert_dn) {
+for my $key (keys %$cert_dn) {
     next unless $key =~ /^server/;
+    my $val = $$cert_dn{$key};
     my $name = join '_', $key, 'dsa';
     $cert_dn->{$name} = { %$val }; #copy
     $cert_dn->{$name}->{OU} =~ s/rsa/dsa/;



Mime
View raw message