Return-Path: X-Original-To: apmail-perl-modperl-archive@www.apache.org Delivered-To: apmail-perl-modperl-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 226CB11930 for ; Mon, 23 Jun 2014 21:06:25 +0000 (UTC) Received: (qmail 96632 invoked by uid 500); 23 Jun 2014 21:06:24 -0000 Delivered-To: apmail-perl-modperl-archive@perl.apache.org Received: (qmail 96611 invoked by uid 500); 23 Jun 2014 21:06:24 -0000 Mailing-List: contact modperl-help@perl.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list modperl@perl.apache.org Received: (qmail 96601 invoked by uid 99); 23 Jun 2014 21:06:23 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Jun 2014 21:06:23 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of Mark.Hedges@ticketmaster.com designates 68.232.137.160 as permitted sender) Received: from [68.232.137.160] (HELO esa4.livenationus.iphmx.com) (68.232.137.160) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Jun 2014 21:06:17 +0000 X-IronPort-AV: E=Sophos;i="5.01,532,1400050800"; d="scan'208";a="1696587" Received: from unknown (HELO USASHEXCAS3.LYV.LiveNation.com) ([209.104.35.200]) by esa4.livenationus.iphmx.com with ESMTP/TLS/AES128-SHA; 23 Jun 2014 14:05:56 -0700 Received: from USASHEXMB02.LYV.LiveNation.com ([fe80::adae:915b:d483:535b]) by USASHEXCAS3.LYV.LiveNation.com ([fe80::3482:3609:dced:e90c%10]) with mapi id 14.03.0123.003; Mon, 23 Jun 2014 17:05:56 -0400 From: Mark Hedges To: "modperl@perl.apache.org" CC: Mark Hedges Subject: bug in Apache2::BuildConfig using trunk and event MPM Thread-Topic: bug in Apache2::BuildConfig using trunk and event MPM Thread-Index: Ac+PJuxOapDKEiQJSP2SW1ydR+lHlA== Date: Mon, 23 Jun 2014 21:05:56 +0000 Message-ID: <55EEF0B3C5BF2744B2248754D717EE4C4B3153@USASHEXMB02.LYV.LiveNation.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.240.17.201] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org It seems like mpm_is_threaded should answer 1 for the event MPM, but it ans= wers 0, and the test fails. The patch works around this by detecting wheth= er it is actually prefork or not, but there may be a deeper problem here. = HTH. -Mark 2014-06-23 14:02:45 Mon $ svn diff ModPerl-Registry/t/prefork.t Index: ModPerl-Registry/t/prefork.t =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- ModPerl-Registry/t/prefork.t (revision 1604925) +++ ModPerl-Registry/t/prefork.t (working copy) @@ -8,9 +8,12 @@ use Apache::TestConfig (); =20 use Apache2::Build (); - my $mpm_is_threaded =3D Apache2::Build->build_config->mpm_is_threaded(); +my $mpm =3D Apache2::Build->build_config->mpm_name(); =20 +t_debug "# mpm_is_threaded: '$mpm_is_threaded'"; +t_debug "# mpm: '$mpm'"; + my %modules =3D ( registry =3D> 'ModPerl::Registry', perlrun =3D> 'ModPerl::PerlRun', @@ -21,7 +24,8 @@ my @aliases =3D sort keys %modules; =20 plan tests =3D> 1*@aliases, need 'mod_alias.c', - { "can't run under threaded MPMs" =3D> !$mpm_is_threaded }; + { "can't run under threaded MPMs" =3D> !$mpm_is_threaded }, + { "works only for prefork" =3D> ($mpm eq 'prefork') }; =20 my $script =3D "prefork.pl"; =20 =20 2014-06-23 14:02:54 Mon $ cd ModPerl-Registry/; t/TEST -verbose t/prefork.= t /ntfhome/local/sbin/httpd -d /ntfhome/local/src/mod_perl2_svn/mod_perl/Mod= Perl-Registry/t -f /ntfhome/local/src/mod_perl2_svn/mod_perl/ModPerl-Regist= ry/t/conf/httpd.conf -D APACHE2 -D PERL_USEITHREADS using Apache/2.2.27 (event MPM) waiting 90 seconds for server to start: ... waiting 90 seconds for server to start: ok (waited 1 secs) server localhost:8529 started t/prefork.t ..=20 # # mpm_is_threaded: '0' # # mpm: 'event' 1..0 # skipped: works only for prefork skipped: works only for prefork Files=3D1, Tests=3D0, 2 wallclock secs ( 0.05 usr 0.02 sys + 0.59 cusr = 0.24 csys =3D 0.90 CPU) Result: NOTESTS [warning] server localhost:8529 shutdown [warning] port 8529 still in use... done