Return-Path: 
 <modperl-return-61184-apmail-perl-modperl-archive=perl.apache.org@perl.apache.org>
Delivered-To: apmail-perl-modperl-archive@www.apache.org
Received: (qmail 20607 invoked from network); 6 Aug 2010 18:17:15 -0000
Received: from unknown (HELO mail.apache.org) (140.211.11.3)
  by 140.211.11.9 with SMTP; 6 Aug 2010 18:17:15 -0000
Received: (qmail 83357 invoked by uid 500); 6 Aug 2010 18:17:14 -0000
Delivered-To: apmail-perl-modperl-archive@perl.apache.org
Received: (qmail 83306 invoked by uid 500); 6 Aug 2010 18:17:13 -0000
Mailing-List: contact modperl-help@perl.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:modperl-help@perl.apache.org>
list-unsubscribe: <mailto:modperl-unsubscribe@perl.apache.org>
List-Post: <mailto:modperl@perl.apache.org>
List-Id: <modperl.perl.apache.org>
Delivered-To: mailing list modperl@perl.apache.org
Received: (qmail 83299 invoked by uid 99); 6 Aug 2010 18:17:13 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Aug 2010 18:17:13 +0000
X-ASF-Spam-Status: No, hits=-0.0 required=10.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: local policy)
Received: from [71.178.236.107] (HELO cell.p6m7g8.net) (71.178.236.107)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Aug 2010 18:17:05 +0000
Received: from philip.hq.rws (wsip-174-79-184-239.dc.dc.cox.net
 [174.79.184.239])
	(authenticated bits=0)
	by cell.p6m7g8.net (8.14.4/8.14.3) with ESMTP id o76IGfCR032234
	(version=TLSv1/SSLv3 cipher=DHE-DSS-CAMELLIA256-SHA bits=256 verify=NO);
	Fri, 6 Aug 2010 18:16:42 GMT
	(envelope-from pgollucci@p6m7g8.com)
Message-ID: <4C5C5189.9030804@p6m7g8.com>
Date: Fri, 06 Aug 2010 18:16:41 +0000
From: "Philip M. Gollucci" <pgollucci@p6m7g8.com>
Organization: P6M7G8 Inc.
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
 rv:1.9.1.9) Gecko/20100607 Thunderbird/3.0.4
MIME-Version: 1.0
To: Cosimo Streppone <cosimo@streppone.it>
CC: Mod_perl users <modperl@perl.apache.org>
Subject: Re: [RELEASE CANDIDATE] Apache-SizeLimit 0.92 RC1
References: <4C59866C.6060105@p6m7g8.com>
 <AANLkTikWOUsvJXiU5zSEcprs0LUOwrJBvSsqwPzaREKZ@mail.gmail.com>
 <op.vg0op607s5ttvb@cd01>
In-Reply-To: <op.vg0op607s5ttvb@cd01>
X-Enigmail-Version: 1.0.1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on cell.p6m7g8.net
X-Virus-Checked: Checked by ClamAV on apache.org
X-Old-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,RDNS_DYNAMIC
	autolearn=no version=3.3.1

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/06/10 12:52, Cosimo Streppone wrote:
> On Wed, Aug 4, 2010 at 8:25 AM, Philip M. Gollucci
> <pgollucci@p6m7g8.com> wrote:
> 
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> http://people.apache.org/~pgollucci/Apache-SizeLimit-0.92-rc1.tar.gz
>> http://people.apache.org/~pgollucci/Apache-SizeLimit-0.92-rc1.tar.gz.md5
>> http://people.apache.org/~pgollucci/Apache-SizeLimit-0.92-rc1.tar.gz.sha256
>>
>> http://people.apache.org/~pgollucci/Apache-SizeLimit-0.92-rc1.tar.gz.asc
> 
> Builds and tests fine both on Debian Lenny w/ Apache 2.2.9
> and perl 5.10 and Ubuntu 10.04.
> 
> I seem to understand that our current SizeLimit config (below) will
> be completely bogus with the new version, right?

>   # Will prevent murders of immature children that just needs to grow a bit
>   $Apache2::SizeLimit::CHECK_EVERY_N_REQUESTS = 30;
> 
>   $Apache2::SizeLimit::MAX_PROCESS_SIZE = 470_000;
>   $Apache2::SizeLimit::MIN_SHARE_SIZE = 50_000;

See the section in Apache2/SizeLimit.pm
=head1 DEPRECATED APIS

<quote>
Direct use of these globals is deprecated, but will continue to work
for the foreseeable future.
</quote>


But it should be trivial to write this instead:
 Apache2::SizeLimit->set_check_interval(30);

 Apache2::SizeLimit->set_max_process_size(470_000);   # Max size in KB
 Apache2::SizeLimit->set_min_shared_size(50_000);     # Min share in KB

- -- 
- ------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
VP Apache Infrastructure; Member, Apache Software Foundation
Committer,                        FreeBSD Foundation
Consultant,                       P6M7G8 Inc.
Sr. System Admin,                 Ridecharge Inc.

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)

iD8DBQFMXFGJdbiP+9ubjBwRArl2AKCN2QxfXfWOkzf9hEA7L+XjhHr7qwCfcsA2
LA0l9nLBEgJKlJErlJMuaKE=
=4yd2
-----END PGP SIGNATURE-----