perl-modperl mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simon Bertrang <ja...@errornet.de>
Subject MP2: Patch to fix dynamic loading under OpenBSD (Was: Patches for two problems under OpenBSD)
Date Sun, 10 Jun 2007 18:38:53 GMT
On Sat, Jun 09, 2007 at 08:22:30PM +0200, Simon Bertrang wrote:
> Hi,
> when porting libapreq2 to OpenBSD we noticed a problem with a workaround
> that doesn't apply anymore (APR.pm):
> 
> $OpenBSD: patch-xs_APR_APR_APR_pm,v 1.1 2007/06/09 16:02:04 martynas Exp $
> --- xs/APR/APR/APR.pm.orig	Mon Nov 20 01:31:02 2006
> +++ xs/APR/APR/APR.pm	Sat Jun  9 18:10:04 2007
> @@ -23,7 +23,7 @@ our @ISA = qw(DynaLoader);
>  # XXX: see xs/ModPerl/Const/Const.pm for issues of using 0x01
>  use Config ();
>  use constant DL_GLOBAL =>
> -  ( $Config::Config{dlsrc} eq 'dl_dlopen.xs' && $^O ne 'openbsd' ) ? 0x01 :
0x0;
> +  ( $Config::Config{dlsrc} eq 'dl_dlopen.xs' ) ? 0x01 : 0x0;
>  sub dl_load_flags { DL_GLOBAL }
>  
>  unless (defined &APR::XSLoader::BOOTSTRAP) {
> 

Here's a diff against svn.
The second thing from my previous mail is fixed already as told by
Jonathan Vanasco.

Regards,
Simon

Index: xs/APR/APR/APR.pm
===================================================================
--- xs/APR/APR/APR.pm	(revision 545917)
+++ xs/APR/APR/APR.pm	(working copy)
@@ -23,7 +23,7 @@
 # XXX: see xs/ModPerl/Const/Const.pm for issues of using 0x01
 use Config ();
 use constant DL_GLOBAL =>
-  ( $Config::Config{dlsrc} eq 'dl_dlopen.xs' && $^O ne 'openbsd' ) ? 0x01 : 0x0;
+  ( $Config::Config{dlsrc} eq 'dl_dlopen.xs' ) ? 0x01 : 0x0;
 sub dl_load_flags { DL_GLOBAL }
 
 unless (defined &APR::XSLoader::BOOTSTRAP) {

Mime
View raw message