perl-modperl mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Torsten Foertsch <>
Subject Re: [PATCH] Apache2::RequestUtil->add_config
Date Sun, 08 Jan 2006 10:37:06 GMT
On Saturday 07 January 2006 18:39, Philip M. Gollucci wrote:
> > As a more generic solution, this might make sense. On first glance, your
> > patch looks sane, but I won't have the time to really look at it until
> > Jan 15th, so if anybody else feels like writing a few tests for this and
> > beat me to it...
> Wouldn't that be an API change ?

I would say an API extension. add_config is prototyped to expect up to 3 
parameters $r, $lines and $override. If called with more it throws an 
exception. Hence, if a new 4th optional parameter is added it cannot break 
any existing code.


View raw message