perl-modperl mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Torsten Foertsch <>
Subject Re: [PATCH]Apache::IncludeHook
Date Wed, 29 Jun 2005 20:05:00 GMT
On Wednesday 29 June 2005 20:33, Geoffrey Young wrote:
> patch applied and will be part of the next release.  since it's the only
> change I might wait a little bit before getting it to CPAN, but probably
> not more than a week.

BTW, I have learned that the first arg to sub is not an Apache2::RequestRec 
but an Apache::IncludeHook object that is based on Apache2::RequestRec. In 
mp1 this arg was the request object and it was okay. Now mod_include is 
implemented as a filter. Hence, the first arg being a Apache2::RequestRec 
looks somewhat unnatural for me. I understand there are portability issues. 
But maybe it would be nice to have the current filter instance accessible via 
the Apache::IncludeHook object? Also some kind of context would be nice since 
$f->ctx seems to be used by mod_include. Sometimes it may be useful to have 
an interface to the base object $r->{_r}. But when the current filter is 
accessible it can be fetched via $r->current_filter->r.

What do you think?


View raw message