Return-Path: Delivered-To: apmail-perl-modperl-archive@www.apache.org Received: (qmail 19865 invoked from network); 5 May 2005 14:38:26 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 5 May 2005 14:38:26 -0000 Received: (qmail 80497 invoked by uid 500); 5 May 2005 14:38:24 -0000 Delivered-To: apmail-perl-modperl-archive@perl.apache.org Received: (qmail 80316 invoked by uid 500); 5 May 2005 14:38:19 -0000 Mailing-List: contact modperl-help@perl.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Delivered-To: mailing list modperl@perl.apache.org Received: (qmail 80136 invoked by uid 99); 5 May 2005 14:38:14 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from mail.logilune.com (HELO mail.logilune.com) (195.80.154.36) by apache.org (qpsmtpd/0.28) with ESMTP; Thu, 05 May 2005 07:38:14 -0700 Received: from [127.0.0.1] (localhost.logilune.com [127.0.0.1]) by mail.logilune.com (Postfix) with ESMTP id 7212CD6933; Thu, 5 May 2005 16:35:31 +0200 (CEST) Message-ID: <427A2F32.2040200@stason.org> Date: Thu, 05 May 2005 07:35:30 -0700 From: Stas Bekman Organization: Hope, Humanized User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6) Gecko/20050322 X-Accept-Language: en-us, en, he, ru MIME-Version: 1.0 To: Steve Hay CC: Markus Wichitill , mod_perl Mailing List Subject: Re: [ANNOUNCE] mod_perl 2.0.0-RC6 References: <42786B13.8040409@stason.org> <4278A5B3.7060302@uk.radan.com> <4278D1C1.3050309@gmx.de> <4279BFC3.60506@stason.org> <4279E73E.4060102@uk.radan.com> In-Reply-To: <4279E73E.4060102@uk.radan.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Steve Hay wrote: > Stas Bekman wrote: > > >>Markus Wichitill wrote: >> >> >> >>>Steve Hay wrote: >>> >>> >>> >>> >>>>Almost all OK on Win32 (Apache 2.0.54 and a recent bleadperl). Main >>>>tests are all successful, but ModPerl-Registry tests failed 404.t test >>>>1 and redirect.t test 2. >>>> >>>> >>> >>>Same here (WinXP, 2.0.54, 5.8.6). modperl_slurp_filename doesn't raise a >>>ENOENT exception when it should. The >>> >>> if (!size) { >>> sv_setpvn(sv, "", 0); >>> return newRV_noinc(sv); >>> } >>> >>>part looks fishy to me. size is 0 and therefore we never get to >>>SLURP_SUCCESS("opening"), which should throw the exception. >>> >>> >> >>Hmm, please see the comment: >> >> /* XXX: could have checked whether r->finfo.filehand is valid and >> * save the apr_file_open call, but apache gives us no API to >> * check whether filehand is valid. we can't test whether it's >> * NULL or not, as it may contain garbagea >> */ >> >>how can we test if the filehandle is valid then? may be we should skip >>that bit altogether? Steve, does it work if you comment out the whole >> >> if (!size) { ... } >> >>block? >> > > No, it doesn't :( > > I even did a complete rebuild in case something didn't get relinked > properly after the change, but it still doesn't fix the two test failures. So what has changed? You didn't have these problems with RC6? Could you trace what change has affected that? Unless Randy or someone who can reproduce that can look at the issue. -- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:stas@stason.org http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com