perl-modperl mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: Why isn't REDIRECT_ERROR_NOTES set in modperl 2?
Date Sun, 02 May 2004 19:58:26 GMT
Rando Christensen wrote:
> The last thing I need to do in order to be able to migrate to apache2 
> is to figure this out. 
> 
> Under apache1.3 and modperl, the error-notes would be properly set to 
> whatever we die() with, just like it would under apache1.3 and a cgi 
> script.
> 
> However, under the newer modperl, this doesn't get set. (Though it does 
> work as I expect under Apache2 with a cgi script instead of mod_perl) 
> What am I doing wrong, and how do I fix this?

I suppose we just haven't got around implementing it yet in the plain handlers 
(Registry has it since 1.99_05). Does the following patch does the trick for 
you, Rando?

Index: src/modules/perl/modperl_callback.c
===================================================================
RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_callback.c,v
retrieving revision 1.70
diff -u -r1.70 modperl_callback.c
--- src/modules/perl/modperl_callback.c 4 Mar 2004 06:01:06 -0000       1.70
+++ src/modules/perl/modperl_callback.c 2 May 2004 19:56:30 -0000
@@ -142,6 +142,12 @@
          status = HTTP_INTERNAL_SERVER_ERROR;
      }

+    if (status == HTTP_INTERNAL_SERVER_ERROR) {
+        if (r && r->notes) {
+            apr_table_set(r->notes, "error-notes", SvPV_nolen(ERRSV));
+        }
+    }
+
      return status;
  }



__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

-- 
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html


Mime
View raw message