perl-modperl mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dave Rolsky <auta...@urth.org>
Subject Bad fix for "fix "PerlSetVar Foo 0" so that $r->dir_config('Foo') returns 0, not undef" in dev tree
Date Mon, 08 Mar 2004 23:21:09 GMT
So this change was incorporated in the latest Debian apache-perl package,
and it causes segfaults when used with Mason.

The trigger seems to be the fact that Mason includes this bit of code
which _may_ be called at server startup:

            my $c = $r ? $r : Apache->server;
            @val = HAS_TABLE_API ? $c->dir_config->get($p) : $c->dir_config($p);

The change in question is this one:

===================================================================
RCS file: /home/cvspublic/modperl/src/modules/perl/Apache.xs,v
retrieving revision 1.129
retrieving revision 1.130
diff -u -r1.129 -r1.130
--- modperl/src/modules/perl/Apache.xs	2003/09/16 19:51:06	1.129
+++ modperl/src/modules/perl/Apache.xs	2003/12/01 17:30:19	1.130
@@ -2084,7 +2084,7 @@
 						 &perl_module);
 	TABLE_GET_SET(c->vars, FALSE);
     }
-    if (!SvTRUE(RETVAL)) {
+    if (!SvOK(RETVAL)) {
 	s = r && r->server ? r->server : perl_get_startup_server();
 	if (s && s->module_config) {
 	    SvREFCNT_dec(RETVAL); /* in case above did newSV(0) */


I don't know why it's blowing up.


-dave

/*=======================
House Absolute Consulting
www.houseabsolute.com
=======================*/

-- 
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html


Mime
View raw message