perl-modperl mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: [mp2] Missing(?) code snipets in porting document
Date Wed, 21 Jan 2004 20:17:51 GMT
Reuben Fischman wrote:
> In going through the porting document for porting to modperl2 and following the Apache::mp3
example, there appears to be some missing code in both http source and the pdf versions of
the document:
> 
>   --- Apache/MP3.pm.4     2003-06-06 15:57:15.000000000 +1000
>   +++ Apache/MP3.pm       2003-06-06 16:04:48.000
>   @@ -1492,7 +1492,7 @@
>      my $suppress_auth = shift;
>      my $r = $self->r;
>   
>   -  my $auth_info;
>   +  my $auth_info = '';
>      # the check for auth_name() prevents an anno
>      # the apache server log when authentication
>      if ($r->auth_name && !$suppress_auth) {
>   @@ -1509,10 +1509,9 @@
>      }
>   
>      my $vhost = $r->hostname;
>   -  unless ($vhost) {
>   -    $vhost = $r->server->server_hostname;
>   -    $vhost .= ':' . $r->get_server_port unless
>   -  }
>   +  $vhost = $r->server->server_hostname unless
>   +  $vhost .= ':' . $r->get_server_port unless $
>   +
>      return "http://${auth_info}${vhost}";
>    }

 > It seems that the second half of the lines is missing (e.g. in the source
 > for MP3.pm, "#the check for auth_name() prevents an anno" actually expands
 > further to be "#the check for auth_name() prevents an annoying......"
 >
 > This missing snipet hasn't affected the port up to this point (FYI, Stas, I
 > got it to work by starting over again), however when I try and continue
 > further in the tutorial I run into errors trying to remove the
 > Apache::compat dependency.  Not sure if this is related to those errors or
 > not, but rather than combine multiple error reports into one email, I
 > figured I'd start with this problem.

May be you are the first person to actually follow it step by step. I thought 
I've tested it, but may be I've forgotten to include some step :( Can you 
complete the missing stage? You do port over the 3.03 version of Apache::MP3, 
do you?

A few things have changed in mp2 since I wrote this document and it really 
needs to be rewritten again, so this may explain the discrepancy. As we are 
now changing several bits of the API, it's worth to wait a bit till the dust 
settles down.

Also Apache::MP3 itself has changed a lot since 3.03, and it's the best to do 
the porting over the latest version of this module.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


-- 
Reporting bugs: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html


Mime
View raw message