Mailing-List: contact modperl-cvs-help@perl.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@perl.apache.org
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r1242010 -
 /perl/modperl/branches/threading/src/modules/perl/mod_perl.c
Date: Wed, 08 Feb 2012 17:46:54 -0000
To: modperl-cvs@perl.apache.org
From: torsten@apache.org
Message-Id: <20120208174654.E71E22388860@eris.apache.org>

Author: torsten
Date: Wed Feb  8 17:46:54 2012
New Revision: 1242010

URL: http://svn.apache.org/viewvc?rev=1242010&view=rev
Log:
comment added

Modified:
    perl/modperl/branches/threading/src/modules/perl/mod_perl.c

Modified: perl/modperl/branches/threading/src/modules/perl/mod_perl.c
URL: http://svn.apache.org/viewvc/perl/modperl/branches/threading/src/modules/perl/mod_perl.c?rev=1242010&r1=1242009&r2=1242010&view=diff
==============================================================================
--- perl/modperl/branches/threading/src/modules/perl/mod_perl.c (original)
+++ perl/modperl/branches/threading/src/modules/perl/mod_perl.c Wed Feb  8 17:46:54 2012
@@ -740,6 +740,14 @@ static int modperl_hook_create_request(r
     MP_dRCFG;
 
 #ifdef USE_ITHREADS
+    /* XXX: this is necessary to make modperl_interp_pool_select() work
+     * which is used at runtime only to merge dir-configs by
+     * modperl_module_config_merge().
+     *
+     * Since most requests won't need it it would be good to add some logic
+     * (cheaper logic in terms of CPU cycles) to identify those cases and
+     * avoid the hash operation.
+     */
     MP_TRACE_i(MP_FUNC, "setting userdata MODPERL_R in pool %#lx to %lx",
                (unsigned long)r->pool, (unsigned long)r);
     (void)apr_pool_userdata_set((void *)r, "MODPERL_R", NULL, r->pool);