Return-Path: Delivered-To: apmail-perl-modperl-cvs-archive@www.apache.org Received: (qmail 283 invoked from network); 6 Feb 2007 04:32:10 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Feb 2007 04:32:10 -0000 Received: (qmail 15624 invoked by uid 500); 6 Feb 2007 04:32:17 -0000 Delivered-To: apmail-perl-modperl-cvs-archive@perl.apache.org Received: (qmail 15605 invoked by uid 500); 6 Feb 2007 04:32:17 -0000 Mailing-List: contact modperl-cvs-help@perl.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@perl.apache.org List-Id: Delivered-To: mailing list modperl-cvs@perl.apache.org Received: (qmail 15594 invoked by uid 99); 6 Feb 2007 04:32:17 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Feb 2007 20:32:17 -0800 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Feb 2007 20:32:09 -0800 Received: by eris.apache.org (Postfix, from userid 65534) id AEC761A981A; Mon, 5 Feb 2007 20:31:49 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r503976 - in /perl/modperl/trunk: Changes ModPerl-Registry/lib/ModPerl/RegistryCooker.pm Date: Tue, 06 Feb 2007 04:31:49 -0000 To: modperl-cvs@perl.apache.org From: stas@apache.org X-Mailer: svnmailer-1.1.0 Message-Id: <20070206043149.AEC761A981A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: stas Date: Mon Feb 5 20:31:48 2007 New Revision: 503976 URL: http://svn.apache.org/viewvc?view=rev&rev=503976 Log: fix ModPerl::RegistryCooker::read_script to handle all possible errors, previously there was a case where Apache2::Const::OK was returned on an error. Contributed by: Eivind Eklund Modified: perl/modperl/trunk/Changes perl/modperl/trunk/ModPerl-Registry/lib/ModPerl/RegistryCooker.pm Modified: perl/modperl/trunk/Changes URL: http://svn.apache.org/viewvc/perl/modperl/trunk/Changes?view=diff&rev=503976&r1=503975&r2=503976 ============================================================================== --- perl/modperl/trunk/Changes (original) +++ perl/modperl/trunk/Changes Mon Feb 5 20:31:48 2007 @@ -12,6 +12,13 @@ =item 2.0.4-dev +fix ModPerl::RegistryCooker::read_script to handle all possible +errors, previously there was a case where Apache2::Const::OK was +returned on an error. [Eivind Eklund ] + +a minor compilation warning resolved in modperl_handler_new_from_sv +[Stas] + a minor compilation warning resolved in modperl_gtop_size_string [Stas] Modified: perl/modperl/trunk/ModPerl-Registry/lib/ModPerl/RegistryCooker.pm URL: http://svn.apache.org/viewvc/perl/modperl/trunk/ModPerl-Registry/lib/ModPerl/RegistryCooker.pm?view=diff&rev=503976&r1=503975&r2=503976 ============================================================================== --- perl/modperl/trunk/ModPerl-Registry/lib/ModPerl/RegistryCooker.pm (original) +++ perl/modperl/trunk/ModPerl-Registry/lib/ModPerl/RegistryCooker.pm Mon Feb 5 20:31:48 2007 @@ -546,9 +546,8 @@ return Apache2::Const::FORBIDDEN if APR::Status::is_EACCES($@); return Apache2::Const::NOT_FOUND if APR::Status::is_ENOENT($@); } - else { - return Apache2::Const::SERVER_ERROR; - } + + return Apache2::Const::SERVER_ERROR; } return Apache2::Const::OK;