Return-Path: Delivered-To: apmail-perl-modperl-cvs-archive@www.apache.org Received: (qmail 33382 invoked from network); 6 Jul 2006 05:57:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 6 Jul 2006 05:57:36 -0000 Received: (qmail 60391 invoked by uid 500); 6 Jul 2006 05:57:36 -0000 Delivered-To: apmail-perl-modperl-cvs-archive@perl.apache.org Received: (qmail 60378 invoked by uid 500); 6 Jul 2006 05:57:36 -0000 Mailing-List: contact modperl-cvs-help@perl.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@perl.apache.org List-Id: Delivered-To: mailing list modperl-cvs@perl.apache.org Delivered-To: moderator for modperl-cvs@perl.apache.org Received: (qmail 92030 invoked by uid 99); 5 Jul 2006 16:02:13 -0000 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r419266 - /perl/Apache-SizeLimit/trunk/t/response/TestApache/basic.pm Date: Wed, 05 Jul 2006 16:01:51 -0000 To: modperl-cvs@perl.apache.org From: autarch@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20060705160152.4C36B1A981A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: autarch Date: Wed Jul 5 09:01:51 2006 New Revision: 419266 URL: http://svn.apache.org/viewvc?rev=419266&view=rev Log: Remove cruft from when this wasn't using -withtestmore. Remove tests of deprecated bits. Don't try to test getppid on Win32, since it appears from the Apache::SizeLimit code that we cannot expect it to return anything useful. Modified: perl/Apache-SizeLimit/trunk/t/response/TestApache/basic.pm Modified: perl/Apache-SizeLimit/trunk/t/response/TestApache/basic.pm URL: http://svn.apache.org/viewvc/perl/Apache-SizeLimit/trunk/t/response/TestApache/basic.pm?rev=419266&r1=419265&r2=419266&view=diff ============================================================================== --- perl/Apache-SizeLimit/trunk/t/response/TestApache/basic.pm (original) +++ perl/Apache-SizeLimit/trunk/t/response/TestApache/basic.pm Wed Jul 5 09:01:51 2006 @@ -7,37 +7,27 @@ use Apache::Constants qw(OK); use Apache::SizeLimit; +use Config; sub handler { my $r = shift; - plan $r, tests => 3; - - Apache::SizeLimit::setmax( 100_000 ); - Apache::SizeLimit::setmin( 1 ); - - ok( $r->pnotes('size_limit_cleanup'), 'Set size_limit_cleanup in pnotes' ); + plan $r, tests => 2; my ( $size, $shared ) = Apache::SizeLimit::check_size(); cmp_ok( $size, '>', 0, 'proc size is reported > 0' ); - cmp_ok( Apache::SizeLimit::real_getppid(), '>', 1, - 'real_getppid() > 1' ); + SKIP: + { + skip 'I have no idea what getppid() on Win32 might return', 1 + if 1 $Config{'osname'} eq 'MSWin32'; + + cmp_ok( Apache::SizeLimit::real_getppid(), '>', 1, + 'real_getppid() > 1' ); + } return OK; -} - -my $count = 1; -sub _test { - my $ok = shift; - my $desc = shift; - my $r = shift; - - my $string = $ok ? 'ok' : 'not ok'; - $r->print( "$string $count - $desc\n" ); - - $count++; }