perl-modperl-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ran...@apache.org
Subject svn commit: r412118 - /perl/modperl/trunk/t/lib/TestAPRlib/finfo.pm
Date Tue, 06 Jun 2006 13:36:34 GMT
Author: randyk
Date: Tue Jun  6 06:36:33 2006
New Revision: 412118

URL: http://svn.apache.org/viewvc?rev=412118&view=rev
Log:
With use of the generated httpd.conf, the utime() call
to touch the file on Win32 so as to ensure it is in the same
DST season is no longer needed (submitted by Steve Hay).

Modified:
    perl/modperl/trunk/t/lib/TestAPRlib/finfo.pm

Modified: perl/modperl/trunk/t/lib/TestAPRlib/finfo.pm
URL: http://svn.apache.org/viewvc/perl/modperl/trunk/t/lib/TestAPRlib/finfo.pm?rev=412118&r1=412117&r2=412118&view=diff
==============================================================================
--- perl/modperl/trunk/t/lib/TestAPRlib/finfo.pm (original)
+++ perl/modperl/trunk/t/lib/TestAPRlib/finfo.pm Tue Jun  6 06:36:33 2006
@@ -36,22 +36,6 @@
     # span across DST season boundaries.
     my $file = catfile Apache::Test::vars->{t_dir}, 'conf', 'httpd.conf';
 
-    # On Win32, touch the file to ensure it is in the same Daylight Saving
-    # Time season as the current time to workaround a bug in Win32's stat()
-    # which APR::Finfo allows for, otherwise the two disagree.
-    #
-    # With perl-5.8.0 on Win32, the syntax
-    #   utime undef, undef, $file;
-    # causes an uninitialized warning to be emitted,
-    # so use the equivalent
-    #   utime $now, $now, $file;
-    # instead.
-    #
-    if (WIN32) {
-        my $now = time;
-        utime $now, $now, $file;
-    }
-
     my $pool = APR::Pool->new();
     # populate the finfo struct first
     my $finfo = APR::Finfo::stat($file, APR::Const::FINFO_NORM, $pool);



Mime
View raw message