perl-modperl-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pgollu...@apache.org
Subject svn commit: r239729 - in /perl/modperl/trunk: Changes Makefile.PL
Date Wed, 24 Aug 2005 18:33:25 GMT
Author: pgollucci
Date: Wed Aug 24 11:33:22 2005
New Revision: 239729

URL: http://svn.apache.org/viewcvs?rev=239729&view=rev
Log:
Fix undefined variable warning in DSO builds when using MP_APXS.

Submitted: Nikolay Ananiev <ananiev@thegdb.com>
Message-ID: <dei8v8$11l$1@sea.gmane.org>

Modified:
    perl/modperl/trunk/Changes
    perl/modperl/trunk/Makefile.PL

Modified: perl/modperl/trunk/Changes
URL: http://svn.apache.org/viewcvs/perl/modperl/trunk/Changes?rev=239729&r1=239728&r2=239729&view=diff
==============================================================================
--- perl/modperl/trunk/Changes (original)
+++ perl/modperl/trunk/Changes Wed Aug 24 11:33:22 2005
@@ -12,6 +12,9 @@
 
 =item 2.0.2-dev
 
+Fix an undefined warning in DSO builds when not using MP_APXS.
+[Nikolay Ananiev <ananiev@thegdb.com>]
+
 When running Makefile.PL with the MP_MAINTAINER=1 option
 add -Wdeclaration-after-statement if we are using gcc
 version 3.3.2 or higher and its not already part of the ccopts.

Modified: perl/modperl/trunk/Makefile.PL
URL: http://svn.apache.org/viewcvs/perl/modperl/trunk/Makefile.PL?rev=239729&r1=239728&r2=239729&view=diff
==============================================================================
--- perl/modperl/trunk/Makefile.PL (original)
+++ perl/modperl/trunk/Makefile.PL Wed Aug 24 11:33:22 2005
@@ -393,9 +393,13 @@
             "You'll need to add the following to httpd.conf:",            "",
             "  LoadModule perl_module modules/$build->{MODPERL_LIB_DSO}", "",
             "depending on your build, mod_perl might not live in",
-            "the modules/ directory - check the results of",              "",
-            "  \$ $build->{MP_APXS} -q LIBEXECDIR",                       "",
-            "and adjust the LoadModule directive accordingly.\n";
+            "the modules/ directory.\n";
+        if ($build->{MP_APXS}) {
+            warning 
+                "Check the results of",                                   "",
+                "  \$ $build->{MP_APXS} -q LIBEXECDIR",                   "",
+                "and adjust the LoadModule directive accordingly.\n";
+        }
     }
 
     $build->save;



Mime
View raw message