perl-modperl-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject cvs commit: modperl-2.0 Changes
Date Fri, 04 Jun 2004 09:38:07 GMT
stas        2004/06/04 02:38:07

  Modified:    xs/APR/Bucket APR__Bucket.h
               .        Changes
  Log:
  provide a workaround for a bug in perl's newSVpvn, so that now
  APR::Bucket's read() returns "" instead of undef when there is no data
  to read.
  
  Revision  Changes    Path
  1.9       +8 -2      modperl-2.0/xs/APR/Bucket/APR__Bucket.h
  
  Index: APR__Bucket.h
  ===================================================================
  RCS file: /home/cvs/modperl-2.0/xs/APR/Bucket/APR__Bucket.h,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -u -r1.8 -r1.9
  --- APR__Bucket.h	31 May 2004 23:41:09 -0000	1.8
  +++ APR__Bucket.h	4 Jun 2004 09:38:06 -0000	1.9
  @@ -52,8 +52,14 @@
           modperl_croak(aTHX_ rc, "APR::Bucket::read");  
       }
   
  -    buf = newSVpvn(str, len);
  -
  +    /* XXX: bug in perl, newSVpvn(NULL, 0) doesn't produce "" sv */
  +    if (len) {
  +        buf = newSVpvn(str, len);
  +    }
  +    else {
  +        buf = newSVpvn("", 0);
  +    }
  +    
       SvTAINTED_on(buf);
       
       return buf;
  
  
  
  1.388     +4 -0      modperl-2.0/Changes
  
  Index: Changes
  ===================================================================
  RCS file: /home/cvs/modperl-2.0/Changes,v
  retrieving revision 1.387
  retrieving revision 1.388
  diff -u -u -r1.387 -r1.388
  --- Changes	4 Jun 2004 04:12:54 -0000	1.387
  +++ Changes	4 Jun 2004 09:38:07 -0000	1.388
  @@ -12,6 +12,10 @@
   
   =item 1.99_15-dev
   
  +provide a workaround for a bug in perl's newSVpvn, so that now
  +APR::Bucket's read() returns "" instead of undef when there is no data
  +to read. [Stas]
  +
   fix a bug in Registry handlers, where the same error was logged twice
   and potentially a wrong error code returned [Stas]
   
  
  
  

Mime
View raw message