perl-modperl-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject cvs commit: modperl-2.0/t/response/TestCompat apache_uri.pm
Date Sat, 29 May 2004 07:34:16 GMT
stas        2004/05/29 00:34:16

  Modified:    t/response/TestCompat apache_uri.pm
  Log:
  enable uri parsing compat tests
  
  Revision  Changes    Path
  1.4       +21 -17    modperl-2.0/t/response/TestCompat/apache_uri.pm
  
  Index: apache_uri.pm
  ===================================================================
  RCS file: /home/cvs/modperl-2.0/t/response/TestCompat/apache_uri.pm,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -u -r1.3 -r1.4
  --- apache_uri.pm	19 Dec 2003 02:40:43 -0000	1.3
  +++ apache_uri.pm	29 May 2004 07:34:16 -0000	1.4
  @@ -16,24 +16,28 @@
   sub handler {
       my $r = shift;
   
  -    plan $r, tests => 1;
  +    plan $r, tests => 19;
   
  -    # XXX: need to test ->parse
  -    #    {
  -    #        my @methods = qw(scheme hostinfo user password hostname path rpath
  -    #                         query fragment port unparse);
  -    #        my $test_uri = "http://foo:bar@perl.apache.org:80/docs/index.html";
  -    # 
  -    #        for my $uri ($r->parsed_uri, Apache::URI->parse($r, $test_uri)) {
  -    #            t_debug("URI=" . $uri->unparse);
  -    #            no strict 'refs';
  -    #            for my $meth (@methods) {
  -    #                my $val = $uri->$meth();
  -    #                t_debug("$meth: $val");
  -    #                ok $val || 1;
  -    #            }
  -    #        }
  -    #    }
  +    {
  +        # XXX: rpath is not implemented and not in compat
  +        my @methods = qw(scheme hostinfo user password hostname path
  +                         query fragment port);
  +        my $test_uri = 'http://foo:bar@perl.apache.org:80/docs?args#frag';
  +
  +        # Apache::URI->parse internally returns an object blessed into
  +        # APR::URI and all the methods are called on that object
  +        for my $uri ($r->parsed_uri, Apache::URI->parse($r, $test_uri)) {
  +            t_debug("URI=" . $uri->unparse);
  +            no strict 'refs';
  +            # just check that methods are call-able, the actual
  +            # testing happens in TestAPR::uri test
  +            for my $meth (@methods) {
  +                my $val = $uri->$meth();
  +                t_debug("$meth: " . ($val||''));
  +                ok $val || 1;
  +            }
  +        }
  +    }
   
       {
           Apache::compat::override_mp2_api('APR::URI::unparse');
  
  
  

Mime
View raw message