perl-modperl-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geoffrey Young <ge...@modperlcookbook.org>
Subject Re: cvs commit: modperl-2.0 Changes
Date Tue, 01 Apr 2003 17:03:35 GMT


stas@apache.org wrote:
> stas        2003/03/31 21:20:51
> 
>   Modified:    xs/Apache/Filter Apache__Filter.h
>                xs/maps  modperl_functions.map
>                xs/tables/current/ModPerl FunctionTable.pm
>                todo     filters.txt
>                .        Changes
>   Added:       t/filter/TestFilter out_str_remove.pm
>                t/filter out_str_remove.t
>   Log:
>   implement $filter->remove (filter self-removal) + tests

the test does not pass for me

filter/out_str_remove....1..1
...
# testing : a filter that removes itself
# expected: 'F_O_O_b_a_r_'
# received: 'F_O_O_'
not ok 1
# Failed test 1 in filter/out_str_remove.t at line 13

truthfully, it looks to me like it's the test data that's wrong - you flush 
between printing 'Foo' and 'bar', sending the data down the chain.  so the 
uppercase filter is uppercasing 'Foo' in one buffer then removing itself, 
never seeing 'bar', which is exactly what I would expect.

--Geoff




Mime
View raw message