perl-modperl-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: cvs commit: modperl Makefile.PL
Date Thu, 20 Feb 2003 22:44:20 GMT
randyk@apache.org wrote:
> randyk      2003/02/20 08:42:46
> 
>   Modified:    .        Makefile.PL
>   Log:
>   Reviewed by:	stas
>   
>   Use Perl's touch(), in case a system touch() isn't available.
>   
>   Revision  Changes    Path
>   1.208     +5 -1      modperl/Makefile.PL
>   
>   Index: Makefile.PL
>   ===================================================================
>   RCS file: /home/cvs/modperl/Makefile.PL,v
>   retrieving revision 1.207
>   retrieving revision 1.208
>   diff -u -r1.207 -r1.208
>   --- Makefile.PL	20 Feb 2003 16:34:35 -0000	1.207
>   +++ Makefile.PL	20 Feb 2003 16:42:46 -0000	1.208
>   @@ -1602,7 +1602,11 @@
>    	my $to = '$(INST_ARCHLIB)/' . "auto/Apache/include/$_";
>    	unless ($self->{PM}->{$from}) {
>    	    $self->{PM}->{$from} = $to;
>   -	    system "$Config{touch} $from";
>   +#	    system "$Config{touch} $from";
>   +	    my @args = ($Config{perlpath}, '-MExtUtils::Command', 
>   +		        '-e', 'touch', $from);
>   +	    system(@args) == 0
>   +	        or die "system @args failed: $?";
>    	}
>        }

since we use cvs, we don't commented out snippets of the older code that was 
replaced with the new one. If in the future we realize the the recent change 
broke something we can always revert to the previous version. So please remove 
this commented out line and the same in your other commit on PERL_SECTIONS. 
Thanks.

BTW, in case you were wondering. the style guide doesn't apply to the modperl 
(1.0) rep, since it's all a mess. We try to keep it clean for 2.0 from the 
very beginning.


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


Mime
View raw message