perl-modperl-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From do...@apache.org
Subject cvs commit: modperl-2.0/xs/Apache/Response Apache__Response.h
Date Tue, 08 May 2001 20:15:17 GMT
dougm       01/05/08 13:15:16

  Modified:    xs/Apache/Response Apache__Response.h
  Log:
  do not need to copy the buffer to be parsed
  
  Revision  Changes    Path
  1.2       +3 -7      modperl-2.0/xs/Apache/Response/Apache__Response.h
  
  Index: Apache__Response.h
  ===================================================================
  RCS file: /home/cvs/modperl-2.0/xs/Apache/Response/Apache__Response.h,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- Apache__Response.h	2001/05/08 18:55:59	1.1
  +++ Apache__Response.h	2001/05/08 20:15:13	1.2
  @@ -1,6 +1,5 @@
  -/* 
  - * pretty sure we need to copy SvPVX, otherwise it will be modified inline
  - * XXX: that might be a desired feature
  +/*
  + * XXX: should do something useful if we end up with any bodytext
    */
   /* XXX: this should probably named $r->cgi_header_parse
    * and send_cgi_header an alias in Apache::compat
  @@ -8,9 +7,6 @@
   #define mpxs_Apache__RequestRec_send_cgi_header(r, sv) \
   { \
       STRLEN len; \
  -    char *buff = SvPV(sv, len); \
  -    char *copy = apr_palloc(r->pool, len+1); \
       const char *bodytext; \
  -    apr_cpystrn(copy, buff, len+1); \
  -    modperl_cgi_header_parse(r, copy, &bodytext); \
  +    modperl_cgi_header_parse(r, SvPV(sv,len), &bodytext); \
   }
  
  
  

Mime
View raw message