perl-modperl-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <sbek...@iname.com>
Subject Re: cvs commit: modperl Makefile.PL Changes
Date Wed, 16 Feb 2000 17:29:02 GMT
> On Fri, 11 Feb 2000, Stas Bekman wrote:
> 
> > >   Modified:    .        Makefile.PL Changes
> > >   Log:
> > >   Look for the makepl_args.mod_perl file as .makepl_args.mod_perl in
> > >   ./ and ../ too since the book says it works so.
> > 
> > Changing the source to match the documentation is a very interesting novel
> > approach I'd say :)
> > 
> > Are you sure you really want to do this? folks might have "hidden" file
> > .makepl_args.mod_perl in .. , not knowing that they have it and hit their
> > head at the wall, not understanding why they supply foo options and the
> > 'perl Makefile.PL' stage and bar options are used instead. 
> > 
> > I would say that at least we need to write in a CAPS something like this:
> > 
> > *** GOING TO USE ../.makepl_args.mod_perl
> > *** ALL SUPPLIED OPTIONS WILL BE OVERRIDEN
> 
> It should say that anyway, probably not with CAPS. :)

At least the *** should be there to draw the attention of the user,
otherwise it's less useful. 

> Is it true that supplied options gets overridden?

I think not. From looking at the code:
the .makepl_args.mod_perl args are pushed at the head of @ARGV
               unshift @ARGV, split /\s+/, $_;

and then they are processed first, so the command line args will override
the ones from makepl_args.mod_perl.

Moreover the note is in the code! I didn't notice it :(

Count this issue as closed.

_______________________________________________________________________
Stas Bekman    mailto:sbekman@iname.com      http://www.stason.org/stas
Perl,CGI,Apache,Linux,Web,Java,PC     http://www.stason.org/stas/TULARC
perl.apache.org    modperl.sourcegarden.org   perlmonth.com    perl.org
single o-> + single o-+ = singlesheaven    http://www.singlesheaven.com


Mime
View raw message