perl-modperl-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Cholet <cho...@logilune.com>
Subject RE: cvs commit: modperl ToDo
Date Wed, 03 Nov 1999 17:56:45 GMT
>   +- "rwrite returned -1", see about taking it out regardless of
>   +  LogLevel, better yet, see if the code can be tweaked to avoid
>   +  reaching this point, must be consuming cpu in a tight loop
>   +

I propose to add the following call at the very start of
write_client():

    if (r->connection->aborted)
        XSRETURN(-1);


That is, return silently (without calling rwrite_neg_trace).
This is what ap_rwrite in http_protocol.c does.

When disconnection is detected the error message is emitted,
subsequent calls to print are silently ignored.

What do you think?

--
Eric


Mime
View raw message