Date: 19 May 1999 19:33:41 -0000
Message-ID: <19990519193341.15316.qmail@hyperreal.org>
From: dougm@hyperreal.org
To: modperl-cvs@hyperreal.org
Subject: cvs commit: modperl Changes Makefile.PL
Sender: modperl-cvs-owner@apache.org
Precedence: bulk
Reply-To: modperl-cvs@apache.org

dougm       99/05/19 12:33:40

  Modified:    .        Changes Makefile.PL
  Log:
  Makefile.PL will now do a handful of sanity checks looking for
  possible broken configurations and offer suggestions for those it
  finds
  
  Revision  Changes    Path
  1.294     +4 -0      modperl/Changes
  
  Index: Changes
  ===================================================================
  RCS file: /export/home/cvs/modperl/Changes,v
  retrieving revision 1.293
  retrieving revision 1.294
  diff -u -r1.293 -r1.294
  --- Changes	1999/05/19 01:03:57	1.293
  +++ Changes	1999/05/19 19:33:36	1.294
  @@ -8,6 +8,10 @@
   
   =item 1.19_01-dev
   
  +Makefile.PL will now do a handful of sanity checks looking for
  +possible broken configurations and offer suggestions for those it
  +finds
  +
   rework PerlFreshRestart to avoid core dump triggered w/ 5.005_03
   
   fix $Apache::Server::Starting under dso
  
  
  
  1.126     +46 -0     modperl/Makefile.PL
  
  Index: Makefile.PL
  ===================================================================
  RCS file: /export/home/cvs/modperl/Makefile.PL,v
  retrieving revision 1.125
  retrieving revision 1.126
  diff -u -r1.125 -r1.126
  --- Makefile.PL	1999/04/07 19:21:41	1.125
  +++ Makefile.PL	1999/05/19 19:33:36	1.126
  @@ -1101,6 +1101,8 @@
   
   $TARGET ||= (is_ssl() ? "httpsd" : "httpd");
   
  +system_sanity_check();
  +
   WriteMakefile(
       #DIR => \@DIR,
       NAME    => "mod_perl",
  @@ -1922,4 +1924,48 @@
       print $apaci_cfg "PERL_THREADS = $yes_no\n";
   
       return $apaci_cfg;
  +}
  +
  +sub phat_warn {
  +    my $msg = shift;
  +	    warn <<EOF;
  +************* WARNING *************
  +
  +  $msg
  +
  +************* WARNING *************
  +EOF
  +  sleep 5;
  +}
  +
  +sub system_sanity_check {
  +    return if $Is_Win32;
  +
  +    my $ccflags = $Config{'ccflags'};
  +    for (split /\s+/, $ccflags) {
  +	next unless s/^-I//;
  +	my $header = "$_/ap_mmn.h";
  +	if (-e $header) {
  +	    phat_warn(<<EOF);
  +Apache headers found in unexpected location: ``$_'', suggestions:
  +   *) Remove via ``rpm -e apache''
  +   *) Remove by hand
  +   *) Complain to your os vendor about their poor layout choice
  +   *) Complain to your sysadmin about their poor layout choice
  +EOF
  +	}
  +    }
  +
  +
  +    if ($USE_DSO and $] < 5.005_56 and 
  +	$^O eq 'solaris' and $Config{'usemymalloc'} eq 'y') 
  +      {
  +	  phat_warn(<<EOF);
  +Your current configuration will most likely trigger core dumps, suggestions:
  +   *) Do not configure mod_perl as a DSO
  +   *) Upgrade your Perl version to 5.005_56 or higher
  +   *) Configure Perl with -Uusemymalloc
  +   *) Switch to an os other than $^O
  +EOF
  +      }
   }