perl-embperl mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Angus Lees <...@inodes.org>
Subject Re: debian package news (was: make test error)
Date Wed, 02 Oct 2002 22:50:32 GMT
At Wed, 2 Oct 2002 14:41:25 +0200, Andre Landwehr wrote:
> On Wed, Oct 02, 2002 at 10:27:03PM +1000, Angus Lees wrote:
> >  ftp://ftp.debian.org/debian/pool/main/libd/libdbix-recordset-perl/libdbix-recordset-perl_0.24-4.diff.gz
> 
> something in that patch broke the PrevNextForm. It does not
> display a next button and the log says:
> 
> Use of uninitialized value in numeric gt (>) at /usr/share/perl5/DBIx/Recordset.pm
line 3114.
> Use of uninitialized value in numeric gt (>) at /usr/share/perl5/DBIx/Recordset.pm
line 3118.


well spotted.  as far as i can tell, this feature wasn't working at
all previously (i've duplicated that effect in some
DBIx::Recordset-using code at least once myself).

here's a patch that should fix it.

 - Gus


Index: Recordset.pm
===================================================================
RCS file: /var/lib/cvs/debian/libdbix-recordset-perl/Recordset.pm,v
retrieving revision 1.3
diff -u -c -r1.3 Recordset.pm
--- Recordset.pm	28 Sep 2002 07:26:18 -0000	1.3
+++ Recordset.pm	2 Oct 2002 22:45:28 -0000
@@ -3111,11 +3111,11 @@
         $buttons .= "$esc<input type=$esc\"text$esc\" size=6 name=$esc\"\$gotorow$esc\"$esc>"
;
         $buttons .= "$esc<input type=$esc\"submit$esc\" name=$esc\"\$goto$esc\" value=$esc\"$textgoto$esc\"$esc>
" ;
         }
-    if ($more > 0 && $textnext)
+    if ($more && $textnext)
         {
         $buttons .= "$esc<input type=$esc\"submit$esc\" name=$esc\"\$next$esc\" value=$esc\"$textnext$esc\"$esc>
" ;
         }
-    if ($more > 0 && $textlast)
+    if ($more && $textlast)
         {
         $buttons .= "$esc<input type=$esc\"submit$esc\" name=$esc\"\$last$esc\" value=$esc\"$textlast$esc\"$esc>"
;
         }

---------------------------------------------------------------------
To unsubscribe, e-mail: embperl-unsubscribe@perl.apache.org
For additional commands, e-mail: embperl-help@perl.apache.org


Mime
View raw message