perl-docs-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: [DocSet] Linking to docs::1.0::os::index doesn't work
Date Mon, 17 Jun 2002 02:59:34 GMT
Per Einar Ellefsen wrote:
> At 18:36 16.06.2002, Per Einar Ellefsen wrote:
> 
>> At 18:17 16.06.2002, Stas Bekman wrote:
>>
>>> Per Einar Ellefsen wrote:
>>>
>>>> Ok, thanks a lot Stas, but that broke all links on Win32 :)
>>>
>>>
>>> well, not that, but extra fixing on top of the index.html fix :) the
>>> s|$base/|| was obviously not crossplatform (notice the trailing /), 
>>> so I thought abs2rel is the only way to do that well. I guess I could 
>>> use substr() on the first char, but who knows what separators are out 
>>> there.
>>>
>>>> I tracked it down to a bug in File::Spec::Win32::abs2rel , which is 
>>>> fixed by the attached patch. I'm not sure if I understood the 
>>>> abs2rel code well enough to submit a patch to p5p though... I'm 
>>>> afraid of breaking other things :(
>>>
>>>
>>> Doh! Too bad :( I don't like the idea of compensating for bugs in the 
>>> code, especially when the bug fix is applied globally (without 
>>> checking $^O eq 'MSWin32'). How about putting an abs2rel in Util.pm 
>>> and do all the bug fixing there? Though we should use the fqdn call 
>>> then, so later it won't be confused with File::Spec's abs2rel.
>>
>>
>> Yes, that would probably be better. My fix doesn't break other 
>> platforms though (uhm, don't know about MacOS), because it only 
>> removed \w with a colon after it, at the beginning of string. Anyway, 
>> I'll do this in Util.pm.
> 
> 
> Here's the patch.

Thanks a lot! committed with a few tweaks.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: docs-dev-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-dev-help@perl.apache.org


Mime
View raw message