<?xml version="1.0" encoding="UTF-8"?>
<feed xmlns="http://www.w3.org/2005/Atom">
<title>dev@perl.apache.org Archives</title>
<link rel="self" href="http://mail-archives.apache.org/mod_mbox/perl-dev/?format=atom"/>
<link href="http://mail-archives.apache.org/mod_mbox/perl-dev/"/>
<id>http://mail-archives.apache.org/mod_mbox/perl-dev/</id>
<updated>2009-12-08T17:29:12Z</updated>
<entry>
<title>Fwd: &lt;Ref682782&gt; AFNIC / ACCUSE RECEPTION MAIL</title>
<author><name>Fred Moyer &lt;fred@redhotpenguin.com&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200912.mbox/%3cad28918e0912071140y62f9255fqd8a92f0d9118bb27@mail.gmail.com%3e"/>
<id>urn:uuid:%3cad28918e0912071140y62f9255fqd8a92f0d9118bb27@mail-gmail-com%3e</id>
<updated>2009-12-07T19:40:54Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
Help! :)  Let's get this guy off the list :)


---------- Forwarded message ----------
From:  &lt;support@afnic.fr&gt;
Date: Mon, Dec 7, 2009 at 11:39 AM
Subject: &lt;Ref682782&gt; AFNIC / ACCUSE RECEPTION MAIL
To: fred@redhotpenguin.com


Bonjour,

Votre courriel "Fwd: svn commit: r888069 -
/perl/modperl/docs/trunk/src/about/pronounce.pod" a bien été reçu par
le support de l'AFNIC et porte le numéro 682782. Il fera l'objet d'un
traitement dès que possible.

Dans l'intervalle, nous vous invitons à consulter notre FAQ et les
actualités des opérations à l'AFNIC :

http://www.afnic.fr/doc/faq
http://www.afnic.fr/operations

Cordialement,
----------
Hello,

AFNIC support has received your message "Fwd: svn commit: r888069 -
/perl/modperl/docs/trunk/src/about/pronounce.pod". We will handle it
as soon as possible.

Regards.
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
Sujet : Fwd: svn commit: r888069 -
/perl/modperl/docs/trunk/src/about/pronounce.pod
N° dossier : 682782
Corps du mail : Just committed this to hopefully kill the warnings we
have been getting.

Thanks to Randy for the great suggestion.


---------- Forwarded message ----------
From:  &lt;phred@apache.org&gt;
Date: Mon, Dec 7, 2009 at 10:34 AM
Subject: svn commit: r888069 - /perl/modperl/docs/trunk/src/about/pronounce.pod
To: docs-cvs@perl.apache.org


Author: phred
Date: Mon Dec  7 18:34:32 2009
New Revision: 888069

URL: http://svn.apache.org/viewvc?rev=888069&amp;view=rev
Log:
Remove blank line which may be causing "spurious '&gt;'" error.

Modified:
   perl/modperl/docs/trunk/src/about/pronounce.pod

Modified: perl/modperl/docs/trunk/src/about/pronounce.pod
URL: http://svn.apache.org/viewvc/perl/modperl/docs/trunk/src/about/pronounce.pod?rev=888069&amp;r1=888068&amp;r2=888069&amp;view=diff
==============================================================================
--- perl/modperl/docs/trunk/src/about/pronounce.pod (original)
+++ perl/modperl/docs/trunk/src/about/pronounce.pod Mon Dec  7 18:34:32 2009
@@ -79,7 +79,6 @@
        &lt;td class="table-bg"&gt;
                &lt;a href="pronounce/pereinar.ogg"&gt;Listen&lt;/a&gt;
        &lt;/td&gt;
-
 &lt;/tr&gt;
 &lt;/table&gt;




---------------------------------------------------------------------
To unsubscribe, e-mail: docs-cvs-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-cvs-help@perl.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org






NOUVEAU: Foire aux Questions (FAQ) dédiée aux Bureaux d'enregistrement AFNIC
http://operations.afnic.fr/fr/faq

--

Pensez-y : toute l'actualité des opérations de l'Afnic est sur
http://operations.afnic.fr/
Support Afnic
Tel: +33 1 39 30 83 00
Fax: +33 1 39 30 83 83
support@afnic.fr

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Fwd: svn commit: r888069 - /perl/modperl/docs/trunk/src/about/pronounce.pod</title>
<author><name>Fred Moyer &lt;fred@redhotpenguin.com&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200912.mbox/%3cad28918e0912071112p60010c65g6bda3f0ad04eff38@mail.gmail.com%3e"/>
<id>urn:uuid:%3cad28918e0912071112p60010c65g6bda3f0ad04eff38@mail-gmail-com%3e</id>
<updated>2009-12-07T19:12:05Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
Just committed this to hopefully kill the warnings we have been getting.

Thanks to Randy for the great suggestion.


---------- Forwarded message ----------
From:  &lt;phred@apache.org&gt;
Date: Mon, Dec 7, 2009 at 10:34 AM
Subject: svn commit: r888069 - /perl/modperl/docs/trunk/src/about/pronounce.pod
To: docs-cvs@perl.apache.org


Author: phred
Date: Mon Dec  7 18:34:32 2009
New Revision: 888069

URL: http://svn.apache.org/viewvc?rev=888069&amp;view=rev
Log:
Remove blank line which may be causing "spurious '&gt;'" error.

Modified:
   perl/modperl/docs/trunk/src/about/pronounce.pod

Modified: perl/modperl/docs/trunk/src/about/pronounce.pod
URL: http://svn.apache.org/viewvc/perl/modperl/docs/trunk/src/about/pronounce.pod?rev=888069&amp;r1=888068&amp;r2=888069&amp;view=diff
==============================================================================
--- perl/modperl/docs/trunk/src/about/pronounce.pod (original)
+++ perl/modperl/docs/trunk/src/about/pronounce.pod Mon Dec  7 18:34:32 2009
@@ -79,7 +79,6 @@
        &lt;td class="table-bg"&gt;
                &lt;a href="pronounce/pereinar.ogg"&gt;Listen&lt;/a&gt;
        &lt;/td&gt;
-
 &lt;/tr&gt;
 &lt;/table&gt;




---------------------------------------------------------------------
To unsubscribe, e-mail: docs-cvs-unsubscribe@perl.apache.org
For additional commands, e-mail: docs-cvs-help@perl.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Re: Apache2::Reload and fatal warnings</title>
<author><name>Ryan Gies &lt;ryan@livesite.net&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200911.mbox/%3c4B0C6D7A.6060400@livesite.net%3e"/>
<id>urn:uuid:%3c4B0C6D7A-6060400@livesite-net%3e</id>
<updated>2009-11-24T23:34:18Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
On 11/23/2009 11:02 PM, dorian taylor wrote:
&gt; Hey guys, been a while.
&gt;
&gt; Was wondering about the behaviour of Apache2::Reload in modules that
&gt; use warnings FATAL =&gt;  'all'; it croaks with a Subroutine foo redefined
&gt; error which of course is remedied by no warnings 'redefine' in the
&gt; offending module. Is there a way to incorporate that into
&gt; Apache2::Reload itself or is the scope too narrow?
&gt;
&gt; Regards,
&gt;    
Set the unload method as so:

   $ModPerl::Util::DEFAULT_UNLOAD_METHOD = 'unload_package_xs';

and you will be good to go.  I am running with a prefork mpm and use
this to aid with thread, i.e., process, reuse issues:

&lt;IfModule prefork.c&gt;
     StartServers       1
     MinSpareServers    1
     MaxSpareServers    1
     ServerLimit        1
     MaxClients         1
     MaxRequestsPerChild  4000
&lt;/IfModule&gt;

The above pragma will also eliminate 'Prototype mismatch' warnings.

Cheers,
-Ryan

OT, would this be better posted to modperl@perl.apache.org?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Apache2::Reload and fatal warnings</title>
<author><name>dorian taylor &lt;dorian.taylor.lists@gmail.com&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200911.mbox/%3cfcd5649a0911232002j4462c2bas4942b2a587039c2d@mail.gmail.com%3e"/>
<id>urn:uuid:%3cfcd5649a0911232002j4462c2bas4942b2a587039c2d@mail-gmail-com%3e</id>
<updated>2009-11-24T04:02:16Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
Hey guys, been a while.

Was wondering about the behaviour of Apache2::Reload in modules that
use warnings FATAL =&gt; 'all'; it croaks with a Subroutine foo redefined
error which of course is remedied by no warnings 'redefine' in the
offending module. Is there a way to incorporate that into
Apache2::Reload itself or is the scope too narrow?

Regards,

-- 
Dorian Taylor
http://doriantaylor.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Re: svn commit: r882407 - /perl/Apache-SizeLimit/trunk/lib/Apache/SizeLimit/Core.pm</title>
<author><name>&quot;Philippe M. Chiasson&quot; &lt;gozer@ectoplasm.org&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200911.mbox/%3c4B06CF07.20609@ectoplasm.org%3e"/>
<id>urn:uuid:%3c4B06CF07-20609@ectoplasm-org%3e</id>
<updated>2009-11-20T17:16:55Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
On 09-11-19 23:09 , Adam Prime wrote:
&gt; Can someone change this ticket to resolved (or whatever is appropriate)
&gt; 
&gt; https://rt.cpan.org/Ticket/Display.html?id=38084
&gt; 
&gt; I can't.

Done. Thanks!

-- 
Philippe M. Chiasson     GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/       m/gozer\@(apache|cpan|ectoplasm)\.org/



</pre>
</div>
</content>
</entry>
<entry>
<title>Re: svn commit: r882407 - /perl/Apache-SizeLimit/trunk/lib/Apache/SizeLimit/Core.pm</title>
<author><name>Adam Prime &lt;adam.prime@utoronto.ca&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200911.mbox/%3c4B061666.6040900@utoronto.ca%3e"/>
<id>urn:uuid:%3c4B061666-6040900@utoronto-ca%3e</id>
<updated>2009-11-20T04:09:10Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
Can someone change this ticket to resolved (or whatever is appropriate)

https://rt.cpan.org/Ticket/Display.html?id=38084

I can't.

Adam

aprime@apache.org wrote:
&gt; Author: aprime
&gt; Date: Fri Nov 20 04:05:37 2009
&gt; New Revision: 882407
&gt; 
&gt; URL: http://svn.apache.org/viewvc?rev=882407&amp;view=rev
&gt; Log:
&gt; Fixed issue with solaris version numbers being treated as decimal numbers, not
&gt; dotted tuples.
&gt; Fixes RT #38084.
&gt; 
&gt; Modified:
&gt;     perl/Apache-SizeLimit/trunk/lib/Apache/SizeLimit/Core.pm
&gt; 
&gt; Modified: perl/Apache-SizeLimit/trunk/lib/Apache/SizeLimit/Core.pm
&gt; URL: http://svn.apache.org/viewvc/perl/Apache-SizeLimit/trunk/lib/Apache/SizeLimit/Core.pm?rev=882407&amp;r1=882406&amp;r2=882407&amp;view=diff
&gt; ==============================================================================
&gt; --- perl/Apache-SizeLimit/trunk/lib/Apache/SizeLimit/Core.pm (original)
&gt; +++ perl/Apache-SizeLimit/trunk/lib/Apache/SizeLimit/Core.pm Fri Nov 20 04:05:37 2009
&gt; @@ -131,7 +131,9 @@
&gt;  }
&gt;  
&gt;  BEGIN {
&gt; -    if ($Config{'osname'} eq 'solaris' &amp;&amp; $Config{'osvers'} &gt;= 2.6 ) {
&gt; +    my ($major,$minor) = split(/\./, $Config{'osvers'});
&gt; +    if ($Config{'osname'} eq 'solaris' &amp;&amp; 
&gt; +        (($major &gt; 2) || ($major == 2 &amp;&amp; $minor &gt;= 6))) {
&gt;          *_platform_check_size   = \&amp;_solaris_2_6_size_check;
&gt;          *_platform_getppid = \&amp;_perl_getppid;
&gt;      }
&gt; 
&gt; 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Re: Apache::SizeLimit + solaris Update 10 (new patch)</title>
<author><name>Adam Prime &lt;adam.prime@utoronto.ca&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200911.mbox/%3c4B019E30.7000202@utoronto.ca%3e"/>
<id>urn:uuid:%3c4B019E30-7000202@utoronto-ca%3e</id>
<updated>2009-11-16T18:47:12Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
Fred Moyer wrote:
&gt; On Mon, Nov 16, 2009 at 8:25 AM, Fred Moyer &lt;fred@redhotpenguin.com&gt; wrote:
&gt;&gt; On Mon, Nov 16, 2009 at 8:07 AM, Adam Prime &lt;adam.prime@utoronto.ca&gt; wrote:
&gt;&gt;&gt; Any comments?
&gt;&gt; Looks pretty safe.  +1
&gt; 
&gt; That being said, I think this line:
&gt; 
&gt; +        ($major &gt; 2 || ($major == 2 &amp;&amp; $minor &gt;= 6))) {
&gt; 
&gt; is better written as
&gt; 
&gt; (($major &gt; 2) or (($major == 2) &amp;&amp; ($minor &gt;= 6))) {
&gt; 
&gt; I can't remember the style guide off the top of my head, I have it
&gt; plugged into my mod_perl perltidy instance.
&gt; 

Sure.

Adam

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Re: Apache::SizeLimit + solaris Update 10 (new patch)</title>
<author><name>Fred Moyer &lt;fred@redhotpenguin.com&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200911.mbox/%3cad28918e0911160827r70be234g3e7b18dc04ef8173@mail.gmail.com%3e"/>
<id>urn:uuid:%3cad28918e0911160827r70be234g3e7b18dc04ef8173@mail-gmail-com%3e</id>
<updated>2009-11-16T16:27:00Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
On Mon, Nov 16, 2009 at 8:25 AM, Fred Moyer &lt;fred@redhotpenguin.com&gt; wrote:
&gt; On Mon, Nov 16, 2009 at 8:07 AM, Adam Prime &lt;adam.prime@utoronto.ca&gt; wrote:
&gt;&gt; Any comments?
&gt;
&gt; Looks pretty safe.  +1

That being said, I think this line:

+        ($major &gt; 2 || ($major == 2 &amp;&amp; $minor &gt;= 6))) {

is better written as

(($major &gt; 2) or (($major == 2) &amp;&amp; ($minor &gt;= 6))) {

I can't remember the style guide off the top of my head, I have it
plugged into my mod_perl perltidy instance.

&gt;
&gt;&gt;
&gt;&gt; Petr Sumbera wrote:
&gt;&gt;&gt;
&gt;&gt;&gt; Fred Moyer wrote:
&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt; On Wed, Nov 11, 2009 at 7:56 PM, Adam Prime &lt;adam.prime@utoronto.ca&gt;
&gt;&gt;&gt;&gt; wrote:
&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt; Petr Sumbera wrote:
&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt; Hi,
&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt; can someone please reevaluate and commit attached patch? I would
love
&gt;&gt;&gt;&gt;&gt;&gt; to
&gt;&gt;&gt;&gt;&gt;&gt; see
&gt;&gt;&gt;&gt;&gt;&gt; it in mod_perl 2.0.5 and 1.32 when they are released..
&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt; Thanks,
&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt; Petr
&gt;&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt;&gt; http://old.nabble.com/file/p26284847/solaris.diff solaris.diff
&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt; If no one objects in the next few day or so i'll commit this (finally)
&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt; Can you post the patch inline to this email so everyone can review it?
&gt;&gt;&gt;
&gt;&gt;&gt; Resending (this time directly).
&gt;&gt;&gt;
&gt;&gt;&gt; Thanks,
&gt;&gt;&gt;
&gt;&gt;&gt; Petr
&gt;&gt;&gt;
&gt;&gt;&gt;
&gt;&gt;&gt; ------------------------------------------------------------------------
&gt;&gt;&gt;
&gt;&gt;&gt;
&gt;&gt;&gt; ---------------------------------------------------------------------
&gt;&gt;&gt; To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
&gt;&gt;&gt; For additional commands, e-mail: dev-help@perl.apache.org
&gt;&gt;
&gt;&gt;
&gt;&gt; ---------------------------------------------------------------------
&gt;&gt; To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
&gt;&gt; For additional commands, e-mail: dev-help@perl.apache.org
&gt;&gt;
&gt;&gt;
&gt;

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Re: Apache::SizeLimit + solaris Update 10 (new patch)</title>
<author><name>Fred Moyer &lt;fred@redhotpenguin.com&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200911.mbox/%3cad28918e0911160825ia8578a9oddf296511f6d25ed@mail.gmail.com%3e"/>
<id>urn:uuid:%3cad28918e0911160825ia8578a9oddf296511f6d25ed@mail-gmail-com%3e</id>
<updated>2009-11-16T16:25:09Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
On Mon, Nov 16, 2009 at 8:07 AM, Adam Prime &lt;adam.prime@utoronto.ca&gt; wrote:
&gt; Any comments?

Looks pretty safe.  +1

&gt;
&gt; Petr Sumbera wrote:
&gt;&gt;
&gt;&gt; Fred Moyer wrote:
&gt;&gt;&gt;
&gt;&gt;&gt; On Wed, Nov 11, 2009 at 7:56 PM, Adam Prime &lt;adam.prime@utoronto.ca&gt;
&gt;&gt;&gt; wrote:
&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt; Petr Sumbera wrote:
&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt; Hi,
&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt; can someone please reevaluate and commit attached patch? I would love
&gt;&gt;&gt;&gt;&gt; to
&gt;&gt;&gt;&gt;&gt; see
&gt;&gt;&gt;&gt;&gt; it in mod_perl 2.0.5 and 1.32 when they are released..
&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt; Thanks,
&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt; Petr
&gt;&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;&gt; http://old.nabble.com/file/p26284847/solaris.diff solaris.diff
&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt; If no one objects in the next few day or so i'll commit this (finally)
&gt;&gt;&gt;
&gt;&gt;&gt; Can you post the patch inline to this email so everyone can review it?
&gt;&gt;
&gt;&gt; Resending (this time directly).
&gt;&gt;
&gt;&gt; Thanks,
&gt;&gt;
&gt;&gt; Petr
&gt;&gt;
&gt;&gt;
&gt;&gt; ------------------------------------------------------------------------
&gt;&gt;
&gt;&gt;
&gt;&gt; ---------------------------------------------------------------------
&gt;&gt; To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
&gt;&gt; For additional commands, e-mail: dev-help@perl.apache.org
&gt;
&gt;
&gt; ---------------------------------------------------------------------
&gt; To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
&gt; For additional commands, e-mail: dev-help@perl.apache.org
&gt;
&gt;

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Re: Apache::SizeLimit + solaris Update 10 (new patch)</title>
<author><name>Adam Prime &lt;adam.prime@utoronto.ca&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200911.mbox/%3c4B0178DA.8010307@utoronto.ca%3e"/>
<id>urn:uuid:%3c4B0178DA-8010307@utoronto-ca%3e</id>
<updated>2009-11-16T16:07:54Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
Any comments?

Petr Sumbera wrote:
&gt; Fred Moyer wrote:
&gt;&gt; On Wed, Nov 11, 2009 at 7:56 PM, Adam Prime &lt;adam.prime@utoronto.ca&gt; 
&gt;&gt; wrote:
&gt;&gt;&gt; Petr Sumbera wrote:
&gt;&gt;&gt;&gt; Hi,
&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt; can someone please reevaluate and commit attached patch? I would 
&gt;&gt;&gt;&gt; love to
&gt;&gt;&gt;&gt; see
&gt;&gt;&gt;&gt; it in mod_perl 2.0.5 and 1.32 when they are released..
&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt; Thanks,
&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt; Petr
&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt; http://old.nabble.com/file/p26284847/solaris.diff solaris.diff
&gt;&gt;&gt; If no one objects in the next few day or so i'll commit this (finally)
&gt;&gt;
&gt;&gt; Can you post the patch inline to this email so everyone can review it?
&gt; 
&gt; Resending (this time directly).
&gt; 
&gt; Thanks,
&gt; 
&gt; Petr
&gt; 
&gt; 
&gt; ------------------------------------------------------------------------
&gt; 
&gt; 
&gt; ---------------------------------------------------------------------
&gt; To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
&gt; For additional commands, e-mail: dev-help@perl.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Re: Apache::SizeLimit + solaris Update 10 (new patch)</title>
<author><name>Petr Sumbera &lt;Petr.Sumbera@Sun.COM&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200911.mbox/%3c4AFBC4F9.9050004@sun.com%3e"/>
<id>urn:uuid:%3c4AFBC4F9-9050004@sun-com%3e</id>
<updated>2009-11-12T08:19:05Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
Content-type: text/plain; CHARSET=US-ASCII; format=flowed
Content-transfer-encoding: 7BIT

Fred Moyer wrote:
&gt; On Wed, Nov 11, 2009 at 7:56 PM, Adam Prime &lt;adam.prime@utoronto.ca&gt; wrote:
&gt;&gt; Petr Sumbera wrote:
&gt;&gt;&gt; Hi,
&gt;&gt;&gt;
&gt;&gt;&gt; can someone please reevaluate and commit attached patch? I would love to
&gt;&gt;&gt; see
&gt;&gt;&gt; it in mod_perl 2.0.5 and 1.32 when they are released..
&gt;&gt;&gt;
&gt;&gt;&gt; Thanks,
&gt;&gt;&gt;
&gt;&gt;&gt; Petr
&gt;&gt;&gt;
&gt;&gt;&gt; http://old.nabble.com/file/p26284847/solaris.diff solaris.diff
&gt;&gt; If no one objects in the next few day or so i'll commit this (finally)
&gt; 
&gt; Can you post the patch inline to this email so everyone can review it?

Resending (this time directly).

Thanks,

Petr


</pre>
</div>
</content>
</entry>
<entry>
<title>Re: Apache::SizeLimit + solaris Update 10 (new patch)</title>
<author><name>Fred Moyer &lt;fred@redhotpenguin.com&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200911.mbox/%3cad28918e0911112219g325843f0i27e9312cfc847a8b@mail.gmail.com%3e"/>
<id>urn:uuid:%3cad28918e0911112219g325843f0i27e9312cfc847a8b@mail-gmail-com%3e</id>
<updated>2009-11-12T06:19:16Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
On Wed, Nov 11, 2009 at 7:56 PM, Adam Prime &lt;adam.prime@utoronto.ca&gt; wrote:
&gt; Petr Sumbera wrote:
&gt;&gt;
&gt;&gt; Hi,
&gt;&gt;
&gt;&gt; can someone please reevaluate and commit attached patch? I would love to
&gt;&gt; see
&gt;&gt; it in mod_perl 2.0.5 and 1.32 when they are released..
&gt;&gt;
&gt;&gt; Thanks,
&gt;&gt;
&gt;&gt; Petr
&gt;&gt;
&gt;&gt; http://old.nabble.com/file/p26284847/solaris.diff solaris.diff
&gt;
&gt; If no one objects in the next few day or so i'll commit this (finally)

Can you post the patch inline to this email so everyone can review it?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Re: Apache::SizeLimit + solaris Update 10 (new patch)</title>
<author><name>Adam Prime &lt;adam.prime@utoronto.ca&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200911.mbox/%3c4AFB877E.9000804@utoronto.ca%3e"/>
<id>urn:uuid:%3c4AFB877E-9000804@utoronto-ca%3e</id>
<updated>2009-11-12T03:56:46Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
Petr Sumbera wrote:
&gt; Hi,
&gt; 
&gt; can someone please reevaluate and commit attached patch? I would love to see
&gt; it in mod_perl 2.0.5 and 1.32 when they are released..
&gt; 
&gt; Thanks,
&gt; 
&gt; Petr
&gt; 
&gt; http://old.nabble.com/file/p26284847/solaris.diff solaris.diff 

If no one objects in the next few day or so i'll commit this (finally)

Adam

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Re: Apache::SizeLimit + solaris Update 10 (new patch)</title>
<author><name>Petr Sumbera &lt;Petr.Sumbera@Sun.COM&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200911.mbox/%3c26284847.post@talk.nabble.com%3e"/>
<id>urn:uuid:%3c26284847-post@talk-nabble-com%3e</id>
<updated>2009-11-10T15:04:31Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>

Hi,

can someone please reevaluate and commit attached patch? I would love to see
it in mod_perl 2.0.5 and 1.32 when they are released..

Thanks,

Petr

http://old.nabble.com/file/p26284847/solaris.diff solaris.diff 
-- 
View this message in context: http://old.nabble.com/Apache%3A%3ASizeLimit-%2B-solaris-Update-10-tp22367060p26284847.html
Sent from the mod_perl - Dev mailing list archive at Nabble.com.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Re: Apache::SizeLimit + solaris Update 10</title>
<author><name>Adam Prime &lt;adam.prime@utoronto.ca&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200910.mbox/%3c4AE0A438.2050100@utoronto.ca%3e"/>
<id>urn:uuid:%3c4AE0A438-2050100@utoronto-ca%3e</id>
<updated>2009-10-22T18:28:08Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
Petr Sumbera wrote:
&gt; What is status of this issue? I don't see any related change in svn.
&gt; 
&gt; Thanks,
&gt; 
&gt; Petr

No one every replied to that last question, and nothing has happened 
since then by the looks of things.

Adam

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Re: Apache::SizeLimit + solaris Update 10</title>
<author><name>Petr Sumbera &lt;Petr.Sumbera@Sun.COM&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200910.mbox/%3c26008045.post@talk.nabble.com%3e"/>
<id>urn:uuid:%3c26008045-post@talk-nabble-com%3e</id>
<updated>2009-10-22T11:01:13Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>

What is status of this issue? I don't see any related change in svn.

Thanks,

Petr


Adam Prime wrote:
&gt; 
&gt; Fred Moyer wrote:
&gt;&gt; On Wed, Mar 18, 2009 at 7:14 PM, Adam Prime &lt;adam.prime@utoronto.ca&gt;
&gt;&gt; wrote:
&gt;&gt;&gt; Fred suggested in resend these patches relative to the root of the
&gt;&gt;&gt; distributions, so here they are.  SizeLimit.patch is against the version
&gt;&gt;&gt; of Apache2::SizeLimit in mod_perl 2.0.4 and generated via git diff.
&gt;&gt;&gt; svn.SizeLimit.patch is against the version of SizeLimit in svn, and was
&gt;&gt;&gt; generated with svn diff.
&gt;&gt; 
&gt;&gt; This git diff doesn't match what I have in svn trunk for
&gt;&gt; Apache2/SizeLimit.pm, 
&gt; 
&gt; Thats because it's against the version in mod_perl 2.0.4, which is 
&gt; nothing like the version that currently in svn.
&gt; 
&gt;&gt; applied to your second part of the patch.  I'd like to see the
&gt;&gt; $major/$minor logic use a couple of more parentheses to spell out
&gt;&gt; exactly what it is doing without having to worry about whether the
&gt;&gt; conditional parser in my head is interpreting this conditional
&gt;&gt; correctly.
&gt; 
&gt; Do you want me to resubmit it like :
&gt; 
&gt;     (($major &gt; 2) || ($major == 2 &amp;&amp; $minor &gt;= 6))
&gt; 
&gt; I'm guessing that's what you mean.
&gt; 
&gt; Adam
&gt; 
&gt; 
&gt;&gt; Index: lib/Apache/SizeLimit/Core.pm
&gt;&gt; ===================================================================
&gt;&gt; --- lib/Apache/SizeLimit/Core.pm        (revision 755867)
&gt;&gt; +++ lib/Apache/SizeLimit/Core.pm        (working copy)
&gt;&gt; @@ -131,7 +131,11 @@
&gt;&gt;  }
&gt;&gt; 
&gt;&gt;  BEGIN {
&gt;&gt; -    if ($Config{'osname'} eq 'solaris' &amp;&amp; $Config{'osvers'} &gt;= 2.6 )
{
&gt;&gt; +     my ($major,$minor) = split('.',$Config{'osvers'});
&gt;&gt; +
&gt;&gt; +     if ($Config{'osname'} eq 'solaris' &amp;&amp;
&gt;&gt; +         ($major &gt; 2 || $major == 2 &amp;&amp; $minor &gt;= 6)) {
&gt;&gt; +
&gt;&gt;          *_platform_check_size   = \&amp;_solaris_2_6_size_check;
&gt;&gt;          *_platform_getppid = \&amp;_perl_getppid;
&gt;&gt; 
&gt;&gt; 
&gt;&gt; 
&gt; 
&gt; ---------------------------------------------------------------------
&gt; To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
&gt; For additional commands, e-mail: dev-help@perl.apache.org
&gt; 
&gt; 
&gt; 

-- 
View this message in context: http://www.nabble.com/Apache%3A%3ASizeLimit-%2B-solaris-Update-10-tp22367060p26008045.html
Sent from the mod_perl - Dev mailing list archive at Nabble.com.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Re: Fwd: &lt;Ref611354&gt; AFNIC / ACCUSE RECEPTION MAIL</title>
<author><name>&quot;Philip M. Gollucci&quot; &lt;pgollucci@p6m7g8.com&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200909.mbox/%3c4ABDB5E3.4090808@p6m7g8.com%3e"/>
<id>urn:uuid:%3c4ABDB5E3-4090808@p6m7g8-com%3e</id>
<updated>2009-09-26T06:34:11Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
Fred Moyer wrote:
&gt; I spoke too soon - kharma needed for this one also.
&gt; 
&gt; Pgollucci, do you have the keys to the list controls?

yes ping me monday directly so I don't forget.
-- 
------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
Consultant          - P6M7G8 Inc.                http://p6m7g8.net
Senior Sys Admin    - RideCharge, Inc.           http://ridecharge.com
ASF Member          - Apache Software Foundation http://apache.org
FreeBSD Committer   - FreeBSD Foundation         http://freebsd.org

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Fwd: &lt;Ref611354&gt; AFNIC / ACCUSE RECEPTION MAIL</title>
<author><name>Fred Moyer &lt;fred@redhotpenguin.com&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200909.mbox/%3cad28918e0909251145j783f0cccx80221f3bb79fe35c@mail.gmail.com%3e"/>
<id>urn:uuid:%3cad28918e0909251145j783f0cccx80221f3bb79fe35c@mail-gmail-com%3e</id>
<updated>2009-09-25T18:45:49Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
I spoke too soon - kharma needed for this one also.

Pgollucci, do you have the keys to the list controls?


---------- Forwarded message ----------
From:  &lt;support@afnic.fr&gt;
Date: Fri, Sep 25, 2009 at 11:43 AM
Subject: &lt;Ref611354&gt; AFNIC / ACCUSE RECEPTION MAIL
To: fred@redhotpenguin.com


Bonjour,

Votre courriel "Fwd: Vacation reply" a bien été reçu par le support de
l'AFNIC et porte le numéro 611354. Il fera l'objet d'un traitement dès
que possible.

Dans l'intervalle, nous vous invitons à consulter notre FAQ et les
actualités des opérations à l'AFNIC :

http://www.afnic.fr/doc/faq
http://www.afnic.fr/operations

Cordialement,
----------
Hello,

AFNIC support has received your message "Fwd: Vacation reply". We will
handle it as soon as possible.

Regards.
&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;&gt;
Sujet : Fwd: Vacation reply
N° dossier : 611354
Corps du mail : Does anyone have the kharma to unsubscribe this guy?
Anyone posting
to the list gets one of this I think:


---------- Forwarded message ----------
From:  &lt;granitegadde@hotmail.com&gt;
Date: Fri, Sep 25, 2009 at 11:14 AM
Subject: Vacation reply
To: fred@redhotpenguin.com


Do not send me an email to this address granitegadde@hotmail.com. This
is an automated reply. I do not use this email
address any more regularly.
Srinivas Gadde.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org






Pensez-y : toute l'actualité des opérations de l'Afnic est sur
http://operations.afnic.fr/

--
Support Afnic
Tel: +33 1 39 30 83 00
Fax: +33 1 39 30 83 83
support@afnic.fr

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Fwd: Vacation reply</title>
<author><name>Fred Moyer &lt;fred@redhotpenguin.com&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200909.mbox/%3cad28918e0909251115k2ba61b0w2d7745341742c127@mail.gmail.com%3e"/>
<id>urn:uuid:%3cad28918e0909251115k2ba61b0w2d7745341742c127@mail-gmail-com%3e</id>
<updated>2009-09-25T18:15:51Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
Does anyone have the kharma to unsubscribe this guy?  Anyone posting
to the list gets one of this I think:


---------- Forwarded message ----------
From:  &lt;granitegadde@hotmail.com&gt;
Date: Fri, Sep 25, 2009 at 11:14 AM
Subject: Vacation reply
To: fred@redhotpenguin.com


Do not send me an email to this address granitegadde@hotmail.com. This
is an automated reply. I do not use this email
address any more regularly.
Srinivas Gadde.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Fwd: Vacation reply</title>
<author><name>Fred Moyer &lt;fred@redhotpenguin.com&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200909.mbox/%3cad28918e0909161443u70889dc0wbec4927698e9c88b@mail.gmail.com%3e"/>
<id>urn:uuid:%3cad28918e0909161443u70889dc0wbec4927698e9c88b@mail-gmail-com%3e</id>
<updated>2009-09-16T21:43:59Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
Does anyone have the kharma to remove this address from the user's list?


---------- Forwarded message ----------
From:  &lt;granitegadde@hotmail.com&gt;
Date: Wed, Sep 16, 2009 at 2:42 PM
Subject: Vacation reply
To: fred@redhotpenguin.com


Do not send me an email to this address granitegadde@hotmail.com. This
is an automated reply. I do not use this email
address any more regularly.
Srinivas Gadde.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Test Failures with 5.10.1 on Linux</title>
<author><name>&quot;David E. Wheeler&quot; &lt;david@kineticode.com&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200909.mbox/%3cF55614B6-144C-4CB1-B4FF-0061DC13C073@kineticode.com%3e"/>
<id>urn:uuid:%3cF55614B6-144C-4CB1-B4FF-0061DC13C073@kineticode-com%3e</id>
<updated>2009-09-15T23:54:39Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
Apache 2.2.13
Perl 5.10.1
Ubuntu Linux 2.6.24-19

Relevant Failures:

t/hooks/authen_basic.t ..................
1..4
# Running under perl version 5.010001 for linux
# Current time local: Tue Sep 15 16:45:32 2009
# Current time GMT:   Tue Sep 15 23:45:32 2009
# Using Test.pm version 1.25_02
# Using Apache/Test.pm version 1.31
ok 1
ok 2
ok 3
not ok 4
# Failed test 4 in t/hooks/authen_basic.t at line 26
Failed 1/4 subtests

t/hooks/authz.t .........................
1..4
# Running under perl version 5.010001 for linux
# Current time local: Tue Sep 15 16:45:33 2009
# Current time GMT:   Tue Sep 15 23:45:33 2009
# Using Test.pm version 1.25_02
# Using Apache/Test.pm version 1.31
ok 1
ok 2
ok 3
not ok 4
# Failed test 4 in t/hooks/authz.t at line 19
Failed 1/4 subtests

Error log and full test verbose output attached.

Best,

David


</pre>
</div>
</content>
</entry>
<entry>
<title>Re: Proposal for CPAN module: Apache2::RequestRec::Time</title>
<author><name>Jan Pazdziora &lt;jpz-mlmp@adelton.com&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200909.mbox/%3c20090911174707.GA28236@relay.adelton.com%3e"/>
<id>urn:uuid:%3c20090911174707-GA28236@relay-adelton-com%3e</id>
<updated>2009-09-11T17:47:07Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
On Fri, Aug 14, 2009 at 06:19:29PM +0200, Jan Pazdziora wrote:
&gt; 
&gt; Having it in core mod_perl is definitelly also an option. 
&gt; 
&gt; That however will not bring the functionality to already-released 
&gt; mod_perl 2 versions around the world. So my idea was to release this 
&gt; module on CPAN and if it gets to mod_perl core eventually, even 
&gt; better.

I have uploaded Apache2-RequestRec-Time-1.0.tar.gz to CPAN. It
provides request_duration_microseconds, request_duration, and
request_time_microseconds (I left out the _hires variants in the
end). I've sent announcement to modperl@perl.apache.org.

Yours,

-- 
Jan Pazdziora

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Sneding mail from Perl</title>
<author><name>kropotkin &lt;enquiries@mms-oxford.com&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200909.mbox/%3c25342957.post@talk.nabble.com%3e"/>
<id>urn:uuid:%3c25342957-post@talk-nabble-com%3e</id>
<updated>2009-09-08T09:46:33Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>

Hello

I don't quite understand the interaction between Perl and sendmail.

If I send an email like this:
  open(MAIL,"|$mailprog -t -oi") or die "mail can't open ";
  print MAIL "To: $recipient\n";
.... other headers and body
close(MAIL);

will Perl have to wait for sendmail (the mail program) to return a value
after open() ? Are there any other delays here?

with thanks

Kropotkin


-- 
View this message in context: http://www.nabble.com/Sneding-mail-from-Perl-tp25342957p25342957.html
Sent from the mod_perl - Dev mailing list archive at Nabble.com.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Re: [Patch] Apache2::Reload</title>
<author><name>Ryan Gies &lt;ryan@livesite.net&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200908.mbox/%3c20090831083810.60fe5600@devbox.lsnllc%3e"/>
<id>urn:uuid:%3c20090831083810-60fe5600@devbox-lsnllc%3e</id>
<updated>2009-08-31T12:38:10Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
On Fri, 28 Aug 2009 21:35:50 -0400
Philippe wrote:

&gt; On 28/08/09 08:35 , Ryan Gies wrote:
&gt; &gt; This patch for Apache2::Reload does two things:
&gt; &gt; 
&gt; &gt;   A) ignores require-hooks which exist in %INC. (fix)
&gt; 
&gt; That's a very good fix indeed, and should be fixed by itself, yes.
&gt; 
&gt; &gt;   B) reloads by file, not module name (fix?)
&gt; 
&gt; Good feature, good patch. I've got only one simple style nit with it.
&gt; 
&gt; Instead of:
&gt; 
&gt; +    foreach my $kvpair (@changed) {
&gt; +        my $name = $ReloadByModuleName ? $kvpair-&gt;[0] : $kvpair-&gt;[1];
&gt; +        require $name;
&gt; 
&gt; 
&gt; I just find $kvpair and $kvpair-&gt;[0] somewhat hard to read, could you
&gt; simply change it to something like:
&gt; 
&gt; +    foreach my $change (@changed) {
&gt; +        my $module = $change-&gt;[0];
&gt; +        my $file = $change-&gt;[1];
&gt; +        my $name = $ReloadByModuleName ? $module: $file;
&gt; +        require $name;

Agreed. I used this style presuming it's equally readable:

        my ($module, $file) = @$change;

&gt; 
&gt; Apart from that, it's a great patch!
&gt; 
&gt; Could you resend 2 patches (splitting A) and B) in different ones)
&gt; with that small concern adressed ?
&gt; 

No problem.  I created patch-B as a diff from patch-A, i.e., it's a 
cumulative patch.  I also bumped $VERSION once for each patch.  I
have only ran tests against the final v0.12 code.

I also introduced a new change in patch-B.  The debug output when an
entry is reloaded uses the format:

  Apache2::Reload: process %d reloading %s from %s\n

the last %s *was* populated with the file's full path.  It is *now*
populated with whatever value was passed to 'require'.  For example, if
you are using the old-style (ReloadByModuleName) method, it will look
like this:

  ... from Apache2/Trace.pm

and by default (new-style) it will look like:

  ... from /usr/local/src/lsn/perl/lib/Apache2/Trace.pm

Please let me know if you have any other changes, questions, or
comments! Cheers,
-Ryan

</pre>
</div>
</content>
</entry>
<entry>
<title>Re: [Patch] Apache2::Reload</title>
<author><name>&quot;Philippe M. Chiasson&quot; &lt;gozer@ectoplasm.org&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200908.mbox/%3c4A9885F6.7010001@ectoplasm.org%3e"/>
<id>urn:uuid:%3c4A9885F6-7010001@ectoplasm-org%3e</id>
<updated>2009-08-29T01:35:50Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
On 28/08/09 08:35 , Ryan Gies wrote:
&gt; This patch for Apache2::Reload does two things:
&gt; 
&gt;   A) ignores require-hooks which exist in %INC. (fix)

That's a very good fix indeed, and should be fixed by itself, yes.

&gt;   B) reloads by file, not module name (fix?)

Good feature, good patch. I've got only one simple style nit with it.

Instead of:

+    foreach my $kvpair (@changed) {
+        my $name = $ReloadByModuleName ? $kvpair-&gt;[0] : $kvpair-&gt;[1];
+        require $name;


I just find $kvpair and $kvpair-&gt;[0] somewhat hard to read, could you
simply change it to something like:

+    foreach my $change (@changed) {
+        my $module = $change-&gt;[0];
+        my $file = $change-&gt;[1];
+        my $name = $ReloadByModuleName ? $module: $file;
+        require $name;

Apart from that, it's a great patch!

Could you resend 2 patches (splitting A) and B) in different ones) with
that small concern adressed ?

-- 
Philippe M. Chiasson     GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/       m/gozer\@(apache|cpan|ectoplasm)\.org/



</pre>
</div>
</content>
</entry>
<entry>
<title>[Patch] Apache2::Reload</title>
<author><name>Ryan Gies &lt;ryan@livesite.net&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200908.mbox/%3c20090828083528.3d8563fe@devbox.lsnllc%3e"/>
<id>urn:uuid:%3c20090828083528-3d8563fe@devbox-lsnllc%3e</id>
<updated>2009-08-28T12:35:28Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
This patch for Apache2::Reload does two things:

  A) ignores require-hooks which exist in %INC. (fix)
  B) reloads by file, not module name (fix?)

I consider B) to be a fix because I cannot imagine why anyone would
want the previous functionality.  As such, the accompanying
configuration variable 'ReloadByModuleName' is used to enabled the old
behavior (as opposed to enabling the new behavior).

I was asked to include this patch inline in this email, however I know
the line-breaks will clobber the diff output, so I have attached it as
well.

Cheers,
-Ryan

--- Apache2/Reload.pm	2009-08-12 10:35:04.000000000 -0400
+++ Apache2/Reload.pm.v0.11	2009-08-28 08:28:25.000000000 -0400
@@ -20,7 +20,7 @@
 
 use mod_perl2;
 
-our $VERSION = '0.10';
+our $VERSION = '0.11';
 
 use Apache2::Const -compile =&gt; qw(OK);
 
@@ -86,6 +86,8 @@
 
     my $DEBUG = ref($o) &amp;&amp; (lc($o-&gt;dir_config("ReloadDebug") || '') eq
'on'); 
+    my $ReloadByModuleName = ref($o) &amp;&amp;
(lc($o-&gt;dir_config("ReloadByModuleName") || '') eq 'on'); +
     my $TouchFile = ref($o) &amp;&amp; $o-&gt;dir_config("ReloadTouchFile");
 
     my $ConstantRedefineWarnings = ref($o) &amp;&amp; 
@@ -138,6 +140,9 @@
         my $file = $Apache2::Reload::INCS{$key};
 
         next unless defined $file;
+        # TODO when $file is a hook, call the hook like require does
to 
+        # determine the path (obtain a file handle). See %INC in
perlvar.
+        next if ref $file;
         next if @watch_dirs &amp;&amp; !grep { $file =~ /^$_/ } @watch_dirs;
         warn "Apache2::Reload: Checking mtime of $key\n" if $DEBUG;
 
@@ -158,24 +163,27 @@
         }
 
         if ($mtime &gt; $Stat{$file}) {
-            push @changed, $key;
+            push @changed, [$key, $file];
         }
         $Stat{$file} = $mtime;
     }
     
     #First, let's unload all changed modules
-    foreach my $module (@changed) {
-        my $package = module_to_package($module);
+    foreach my $kvpair (@changed) {
+        my $package = module_to_package($kvpair-&gt;[0]);
         ModPerl::Util::unload_package($package);
     }
-    
-    #Then, let's reload them all, so that module dependencies can
satisfy
-    #themselves in the correct order.
-    foreach my $module (@changed) {
-        my $package = module_to_package($module);
-        require $module;
-        warn("Apache2::Reload: process $$ reloading $package from
$module\n")
-            if $DEBUG;
+
+    #Then, let's reload each changed file, so that module dependencies
can 
+    #satisfy themselves in the correct order.
+    foreach my $kvpair (@changed) {
+        my $name = $ReloadByModuleName ? $kvpair-&gt;[0] : $kvpair-&gt;[1];
+        require $name;
+        if ($DEBUG) {
+          my $package = module_to_package($kvpair-&gt;[0]);
+          warn sprintf("Apache2::Reload: process %d reloading %s from
%s\n",
+            $$, $package, $kvpair-&gt;[1]);
+        }
     }
 
     return Apache2::Const::OK;
@@ -206,6 +214,7 @@
   PerlSetVar ReloadAll Off
   PerlSetVar ReloadModules "ModPerl::* Apache2::*"
   #PerlSetVar ReloadDebug On
+  #PerlSetVar ReloadByModuleName On
   
   # Reload a single module from within itself:
   package My::Apache2::Module;
@@ -226,16 +235,28 @@
 also do the check for modified modules, when a special touch-file has
 been modified.
 
-Note that C&lt;Apache2::Reload&gt; operates on the current context of
-C&lt;@INC&gt;.  Which means, when called as a C&lt;Perl*Handler&gt; it will not
-see C&lt;@INC&gt; paths added or removed by C&lt;ModPerl::Registry&gt; scripts, as
-the value of C&lt;@INC&gt; is saved on server startup and restored to that
-value after each request.  In other words, if you want
-C&lt;Apache2::Reload&gt; to work with modules that live in custom C&lt;@INC&gt;
-paths, you should modify C&lt;@INC&gt; when the server is started.  Besides,
-C&lt;'use lib'&gt; in the startup script, you can also set the C&lt;PERL5LIB&gt;
-variable in the httpd's environment to include any non-standard 'lib'
-directories that you choose.  For example, to accomplish that you can
+Require-hooks, i.e., entries in %INC which are references, are
ignored.  The +hook should modify %INC itself, adding the path to the
module file, for it to +be reloaded.
+
+C&lt;Apache2::Reload&gt; inspects and reloads the B&lt;file&gt; associated with a
given +module.  Changes to @INC are not recognized, as it is the file
which is +being re-required, not the module name.
+
+In version 0.10 and earlier the B&lt;module name&gt;, not the file, is
re-required. +Meaning it operated on the the current context of @INC.
If you still want this +behavior set this environment variable in
I&lt;httpd.conf&gt;: +
+  PerlSetVar ReloadByModuleName On
+
+This means, when called as a C&lt;Perl*Handler&gt;, C&lt;Apache2::Reload&gt; will
not see +C&lt;@INC&gt; paths added or removed by C&lt;ModPerl::Registry&gt;
scripts, as the value of +C&lt;@INC&gt; is saved on server startup and
restored to that value after each +request.  In other words, if you
want C&lt;Apache2::Reload&gt; to work with modules +that live in custom
C&lt;@INC&gt; paths, you should modify C&lt;@INC&gt; when the server is +started.
Besides, C&lt;'use lib'&gt; in the startup script, you can also set the
+C&lt;PERL5LIB&gt; variable in the httpd's environment to include any
non-standard +'lib' directories that you choose.  For example, to
accomplish that you can include a line: 
   PERL5LIB=/home/httpd/perl/extra; export PERL5LIB

</pre>
</div>
</content>
</entry>
<entry>
<title>Re: svn commit: r807116 - in /perl/modperl/trunk: Changes 	lib/Apache2/Build.pm lib/ModPerl/BuildMM.pm lib/ModPerl/MM.pm</title>
<author><name>&quot;Philippe M. Chiasson&quot; &lt;gozer@apache.org&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200908.mbox/%3c4A92FAC5.10708@apache.org%3e"/>
<id>urn:uuid:%3c4A92FAC5-10708@apache-org%3e</id>
<updated>2009-08-24T20:40:37Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
On 24/08/09 15:54 , Fred Moyer wrote:
&gt; On Mon, Aug 24, 2009 at 11:31 AM, Torsten
&gt; Foertsch&lt;torsten.foertsch@gmx.net&gt; wrote:
&gt;&gt; On Mon 24 Aug 2009, Philippe M. Chiasson wrote:
&gt;&gt;&gt;&gt; Modified: perl/modperl/trunk/lib/Apache2/Build.pm
&gt;&gt;&gt;&gt; URL:
&gt;&gt;&gt;&gt; http://svn.apache.org/viewvc/perl/modperl/trunk/lib/Apache2/Build.p
&gt;&gt;&gt;&gt; m?rev=807116&amp;r1=807115&amp;r2=807116&amp;view=diff
&gt;&gt;&gt;&gt; ===================================================================
&gt;&gt;&gt;&gt; =========== --- perl/modperl/trunk/lib/Apache2/Build.pm (original)
&gt;&gt;&gt;&gt; +++ perl/modperl/trunk/lib/Apache2/Build.pm Mon Aug 24 08:29:43
&gt;&gt;&gt;&gt; 2009 @@ -2068,6 +2068,7 @@
&gt;&gt;&gt;&gt;  }
&gt;&gt;&gt;&gt;
&gt;&gt;&gt;&gt;  sub inc {
&gt;&gt;&gt;&gt; +    local $_;
&gt;&gt;&gt;&gt;      my @includes = map { "-I$_" } @{ shift-&gt;includes };
&gt;&gt;&gt;&gt;      "@includes";
&gt;&gt;&gt;&gt;  }
&gt;&gt;&gt;
&gt;&gt;&gt; With the rest of the changes in this patch, is this particular change
&gt;&gt;&gt; still necessary?
&gt;&gt;
&gt;&gt; Not really, but it's a safety measure. The "for ()" idiom is used in
&gt;&gt; many places. And I know these pieces of code that had bitten me now are
&gt;&gt; years old. Don't know why it happened now. So, I'd like to have it
&gt;&gt; there.
&gt; 
&gt; What about replacing the for () instances with 'for my'?  'local $_'
&gt; may affect other parts of the code that haven't been looked at -
&gt; that's my concern with that approach.

Well said, same concern here.

-- 
Philippe M. Chiasson     GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/       m/gozer\@(apache|cpan|ectoplasm)\.org/



</pre>
</div>
</content>
</entry>
<entry>
<title>Re: svn commit: r807116 - in /perl/modperl/trunk: Changes	lib/Apache2/Build.pm lib/ModPerl/BuildMM.pm lib/ModPerl/MM.pm</title>
<author><name>Fred Moyer &lt;fred@redhotpenguin.com&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200908.mbox/%3cad28918e0908241254m4ef9a470l32eba354dc3df050@mail.gmail.com%3e"/>
<id>urn:uuid:%3cad28918e0908241254m4ef9a470l32eba354dc3df050@mail-gmail-com%3e</id>
<updated>2009-08-24T19:54:18Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
On Mon, Aug 24, 2009 at 11:31 AM, Torsten
Foertsch&lt;torsten.foertsch@gmx.net&gt; wrote:
&gt; On Mon 24 Aug 2009, Philippe M. Chiasson wrote:
&gt;&gt; &gt; Modified: perl/modperl/trunk/lib/Apache2/Build.pm
&gt;&gt; &gt; URL:
&gt;&gt; &gt; http://svn.apache.org/viewvc/perl/modperl/trunk/lib/Apache2/Build.p
&gt;&gt; &gt;m?rev=807116&amp;r1=807115&amp;r2=807116&amp;view=diff
&gt;&gt; &gt; ===================================================================
&gt;&gt; &gt;=========== --- perl/modperl/trunk/lib/Apache2/Build.pm (original)
&gt;&gt; &gt; +++ perl/modperl/trunk/lib/Apache2/Build.pm Mon Aug 24 08:29:43
&gt;&gt; &gt; 2009 @@ -2068,6 +2068,7 @@
&gt;&gt; &gt;  }
&gt;&gt; &gt;
&gt;&gt; &gt;  sub inc {
&gt;&gt; &gt; +    local $_;
&gt;&gt; &gt;      my @includes = map { "-I$_" } @{ shift-&gt;includes };
&gt;&gt; &gt;      "@includes";
&gt;&gt; &gt;  }
&gt;&gt;
&gt;&gt; With the rest of the changes in this patch, is this particular change
&gt;&gt; still necessary?
&gt;
&gt; Not really, but it's a safety measure. The "for ()" idiom is used in
&gt; many places. And I know these pieces of code that had bitten me now are
&gt; years old. Don't know why it happened now. So, I'd like to have it
&gt; there.

What about replacing the for () instances with 'for my'?  'local $_'
may affect other parts of the code that haven't been looked at -
that's my concern with that approach.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Re: svn commit: r807116 - in /perl/modperl/trunk: Changes lib/Apache2/Build.pm lib/ModPerl/BuildMM.pm lib/ModPerl/MM.pm</title>
<author><name>Torsten Foertsch &lt;torsten.foertsch@gmx.net&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200908.mbox/%3c200908242031.51182.torsten.foertsch@gmx.net%3e"/>
<id>urn:uuid:%3c200908242031-51182-torsten-foertsch@gmx-net%3e</id>
<updated>2009-08-24T18:31:51Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
On Mon 24 Aug 2009, Philippe M. Chiasson wrote:
&gt; &gt; Modified: perl/modperl/trunk/lib/Apache2/Build.pm
&gt; &gt; URL:
&gt; &gt; http://svn.apache.org/viewvc/perl/modperl/trunk/lib/Apache2/Build.p
&gt; &gt;m?rev=807116&amp;r1=807115&amp;r2=807116&amp;view=diff
&gt; &gt; ===================================================================
&gt; &gt;=========== --- perl/modperl/trunk/lib/Apache2/Build.pm (original)
&gt; &gt; +++ perl/modperl/trunk/lib/Apache2/Build.pm Mon Aug 24 08:29:43
&gt; &gt; 2009 @@ -2068,6 +2068,7 @@
&gt; &gt;  }
&gt; &gt;  
&gt; &gt;  sub inc {
&gt; &gt; +    local $_;
&gt; &gt;      my @includes = map { "-I$_" } @{ shift-&gt;includes };
&gt; &gt;      "@includes";
&gt; &gt;  }
&gt;
&gt; With the rest of the changes in this patch, is this particular change
&gt; still necessary?

Not really, but it's a safety measure. The "for ()" idiom is used in 
many places. And I know these pieces of code that had bitten me now are 
years old. Don't know why it happened now. So, I'd like to have it 
there.

Torsten

-- 
Need professional mod_perl support?
Just hire me: torsten.foertsch@gmx.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Re: svn commit: r807116 - in /perl/modperl/trunk: Changes lib/Apache2/Build.pm lib/ModPerl/BuildMM.pm lib/ModPerl/MM.pm</title>
<author><name>&quot;Philippe M. Chiasson&quot; &lt;gozer@ectoplasm.org&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200908.mbox/%3c4A92CF55.5010605@ectoplasm.org%3e"/>
<id>urn:uuid:%3c4A92CF55-5010605@ectoplasm-org%3e</id>
<updated>2009-08-24T17:35:17Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
On 24/08/09 04:29 , torsten@apache.org wrote:
&gt; Author: torsten
&gt; Date: Mon Aug 24 08:29:43 2009
&gt; New Revision: 807116
&gt; 
&gt; URL: http://svn.apache.org/viewvc?rev=807116&amp;view=rev
&gt; Log:
&gt; Fix a typo in ModPerl::BuildMM. Fix a compile time issue by introducing
&gt; lexically scoped loop variables in ModPerl::MM::WriteMakefile().

Great, thanks for the fixes!

&gt; Modified:
&gt;     perl/modperl/trunk/Changes
&gt;     perl/modperl/trunk/lib/Apache2/Build.pm
&gt;     perl/modperl/trunk/lib/ModPerl/BuildMM.pm
&gt;     perl/modperl/trunk/lib/ModPerl/MM.pm
&gt; 
&gt; Modified: perl/modperl/trunk/Changes
&gt; URL: http://svn.apache.org/viewvc/perl/modperl/trunk/Changes?rev=807116&amp;r1=807115&amp;r2=807116&amp;view=diff
&gt; ==============================================================================
&gt; --- perl/modperl/trunk/Changes (original)
&gt; +++ perl/modperl/trunk/Changes Mon Aug 24 08:29:43 2009
&gt; @@ -12,6 +12,9 @@
&gt;  
&gt;  =item 2.0.5-dev
&gt;  
&gt; +Fix a typo in ModPerl::BuildMM and introduce lexically scoped loop
&gt; +variables in ModPerl::MM::WriteMakefile(). [Torsten Foertsch]

I'd reword that to be a bit more descriptive to the folks likely to be reading
this to determine if they should update. Something like:

"MODPERL_INC= now correctly supported as an argument to Makefile.PL"

The lexically scoped loop variables should have no impact at all to a potential
upgrader, so it doesn't really need to be mentionned.

&gt;  Fix an XSS issue in Apache2::Status reported by Richard J. Brain
&gt;  &lt;richard@procheckup.com&gt;. [Torsten Foertsch]
&gt;  
&gt; 
&gt; Modified: perl/modperl/trunk/lib/Apache2/Build.pm
&gt; URL: http://svn.apache.org/viewvc/perl/modperl/trunk/lib/Apache2/Build.pm?rev=807116&amp;r1=807115&amp;r2=807116&amp;view=diff
&gt; ==============================================================================
&gt; --- perl/modperl/trunk/lib/Apache2/Build.pm (original)
&gt; +++ perl/modperl/trunk/lib/Apache2/Build.pm Mon Aug 24 08:29:43 2009
&gt; @@ -2068,6 +2068,7 @@
&gt;  }
&gt;  
&gt;  sub inc {
&gt; +    local $_;
&gt;      my @includes = map { "-I$_" } @{ shift-&gt;includes };
&gt;      "@includes";
&gt;  }

With the rest of the changes in this patch, is this particular change still
necessary?

-- 
Philippe M. Chiasson     GPG: F9BFE0C2480E7680 1AE53631CB32A107 88C3A5A5
http://gozer.ectoplasm.org/       m/gozer\@(apache|cpan|ectoplasm)\.org/



</pre>
</div>
</content>
</entry>
<entry>
<title>Re: locality of $_ in ModPerl::MM and the like</title>
<author><name>Fred Moyer &lt;fred@redhotpenguin.com&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200908.mbox/%3cad28918e0908231328v49853648ncd8baeb954ae7505@mail.gmail.com%3e"/>
<id>urn:uuid:%3cad28918e0908231328v49853648ncd8baeb954ae7505@mail-gmail-com%3e</id>
<updated>2009-08-23T20:28:39Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
On Sun, Aug 23, 2009 at 9:03 AM, Torsten
Foertsch&lt;torsten.foertsch@gmx.net&gt; wrote:
&gt; Hi,
&gt;
&gt; recently I stumbled upon a curious thing. A freshly unpacked modperl
&gt; aborted compilation after compiling in src/modules/perl. These are the
&gt; symptoms:

....


+1 to this patch.  Has the added benefit of using a lexical loop
variable which is a better practice than 'for ... $_' in my humble
opinion.

&gt; This patch introduces $o as loop variable instead of $_. For me the
&gt; @default_opts loop was the culprit but I have changed all loops in
&gt; WriteMakefile().
&gt;
&gt; Index: lib/ModPerl/MM.pm
&gt; ===================================================================
&gt; --- lib/ModPerl/MM.pm   (revision 806134)
&gt; +++ lib/ModPerl/MM.pm   (working copy)
&gt; @@ -132,22 +132,22 @@
&gt;     my_import(__PACKAGE__);
&gt;
&gt;     # set top-level WriteMakefile's values if weren't set already
&gt; -    for (@default_opts) {
&gt; -        $args{$_} = get_def_opt($_) unless exists $args{$_}; # already defined
&gt; +    for my $o (@default_opts) {
&gt; +        $args{$o} = get_def_opt($o) unless exists $args{$o}; # already defined
&gt;     }
&gt;
&gt;     # set dynamic_lib-level WriteMakefile's values if weren't set already
&gt;     $args{dynamic_lib} ||= {};
&gt;     my $dlib = $args{dynamic_lib};
&gt; -    for (@default_dlib_opts) {
&gt; -        $dlib-&gt;{$_} = get_def_opt($_) unless exists $dlib-&gt;{$_};
&gt; +    for my $o (@default_dlib_opts) {
&gt; +        $dlib-&gt;{$o} = get_def_opt($o) unless exists $dlib-&gt;{$o};
&gt;     }
&gt;
&gt;     # set macro-level WriteMakefile's values if weren't set already
&gt;     $args{macro} ||= {};
&gt;     my $macro = $args{macro};
&gt; -    for (@default_macro_opts) {
&gt; -        $macro-&gt;{$_} = get_def_opt($_) unless exists $macro-&gt;{$_};
&gt; +    for my $o (@default_macro_opts) {
&gt; +        $macro-&gt;{$o} = get_def_opt($o) unless exists $macro-&gt;{$o};
&gt;     }
&gt;
&gt;     ExtUtils::MakeMaker::WriteMakefile(%args);

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>locality of $_ in ModPerl::MM and the like</title>
<author><name>Torsten Foertsch &lt;torsten.foertsch@gmx.net&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200908.mbox/%3c200908231803.31358.torsten.foertsch@gmx.net%3e"/>
<id>urn:uuid:%3c200908231803-31358-torsten-foertsch@gmx-net%3e</id>
<updated>2009-08-23T16:03:31Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
Hi,

recently I stumbled upon a curious thing. A freshly unpacked modperl 
aborted compilation after compiling in src/modules/perl. These are the 
symptoms:

- during perl Makefile.PL:

...
WARNING: #define AP_SERVER_MAJORVERSION_NUMBER 2
 is not a known parameter.
Checking if your kit is complete...
Looks good
Writing Makefile for Apache2::Reload
!!! no default argument defined for argument: #define 
AP_SERVER_MAJORVERSION_NUMBER 2
 at ./Makefile.PL line 60
WARNING: #define AP_SERVER_MAJORVERSION_NUMBER 2
 is not a known parameter.
Checking if your kit is complete...
Looks good

- and then in make:

...
cp lib/Apache2/porting.pm blib/lib/Apache2/porting.pm
make[1]: Entering directory 
`/usr/src/packages/BUILD/mod_perl-2.0.5threading3/Apache-Reload'
Makefile:14: *** empty variable name.  Stop.
make[1]: Leaving directory 
`/usr/src/packages/BUILD/mod_perl-2.0.5threading3/Apache-Reload'
make: *** [subdirs] Error 2

A second call of "perl Makefile.PL; make" made it work normally.

I could track it down to $_ being used as loop variable and overwritten 
by a function called in that loop in ModPerl::MM.

There are obviously 2 ways to fix that. First, introduce a local loop 
variable and second, ensure $_ is not changed inside a function unless 
this is the purpose of the function.

What is the way to go? Or are both ways ok?

This patch introduces $o as loop variable instead of $_. For me the
@default_opts loop was the culprit but I have changed all loops in
WriteMakefile().

Index: lib/ModPerl/MM.pm
===================================================================
--- lib/ModPerl/MM.pm	(revision 806134)
+++ lib/ModPerl/MM.pm	(working copy)
@@ -132,22 +132,22 @@
     my_import(__PACKAGE__);
 
     # set top-level WriteMakefile's values if weren't set already
-    for (@default_opts) {
-        $args{$_} = get_def_opt($_) unless exists $args{$_}; # already defined
+    for my $o (@default_opts) {
+        $args{$o} = get_def_opt($o) unless exists $args{$o}; # already defined
     }
 
     # set dynamic_lib-level WriteMakefile's values if weren't set already
     $args{dynamic_lib} ||= {};
     my $dlib = $args{dynamic_lib};
-    for (@default_dlib_opts) {
-        $dlib-&gt;{$_} = get_def_opt($_) unless exists $dlib-&gt;{$_};
+    for my $o (@default_dlib_opts) {
+        $dlib-&gt;{$o} = get_def_opt($o) unless exists $dlib-&gt;{$o};
     }
 
     # set macro-level WriteMakefile's values if weren't set already
     $args{macro} ||= {};
     my $macro = $args{macro};
-    for (@default_macro_opts) {
-        $macro-&gt;{$_} = get_def_opt($_) unless exists $macro-&gt;{$_};
+    for my $o (@default_macro_opts) {
+        $macro-&gt;{$o} = get_def_opt($o) unless exists $macro-&gt;{$o};
     }
 
     ExtUtils::MakeMaker::WriteMakefile(%args);

And this one prevents inc() from changing $_:

Index: lib/Apache2/Build.pm
===================================================================
--- lib/Apache2/Build.pm	(revision 806134)
+++ lib/Apache2/Build.pm	(working copy)
@@ -2068,6 +2068,7 @@
 }
 
 sub inc {
+    local $_;
     my @includes = map { "-I$_" } @{ shift-&gt;includes };
     "@includes";
 }


The attached patch contains these 2 plus a fix for the typo mentioned
in my previous mail.

Can I apply it to trunk?

Torsten


</pre>
</div>
</content>
</entry>
<entry>
<title>What does it mean?</title>
<author><name>Torsten Foertsch &lt;torsten.foertsch@gmx.net&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200908.mbox/%3c200908231549.19482.torsten.foertsch@gmx.net%3e"/>
<id>urn:uuid:%3c200908231549-19482-torsten-foertsch@gmx-net%3e</id>
<updated>2009-08-23T13:49:19Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
Hi,

in lib/ModPerl/BuildMM.pm:WriteMakefile() I found these lines (80-83):

    my $inc;
    $inc = $args{INC} if $args{INC};
    $inc = " " . $build-&gt;inc;

Shouldn't the last one read instead:

    $inc .= " " . $build-&gt;inc;

Torsten

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>[PATCH] Re: Apache::Test problem</title>
<author><name>Torsten Foertsch &lt;torsten.foertsch@gmx.net&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200908.mbox/%3c200908211651.24111.torsten.foertsch@gmx.net%3e"/>
<id>urn:uuid:%3c200908211651-24111-torsten-foertsch@gmx-net%3e</id>
<updated>2009-08-21T14:51:24Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
On Fri 21 Aug 2009, Torsten Foertsch wrote:
&gt; I think the whole reconfig thing should be skipped
&gt; with -run-tests.

How about the enclosed patch? I don't know enough about AT to judge. So, 
please comment.

Torsten

-- 
Need professional mod_perl support?
Just hire me: torsten.foertsch@gmx.net


</pre>
</div>
</content>
</entry>
<entry>
<title>Apache::Test problem</title>
<author><name>Torsten Foertsch &lt;torsten.foertsch@gmx.net&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200908.mbox/%3c200908211339.04251.torsten.foertsch@gmx.net%3e"/>
<id>urn:uuid:%3c200908211339-04251-torsten-foertsch@gmx-net%3e</id>
<updated>2009-08-21T11:39:04Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
Hi,

I thought I had found an issue in t/api/add_config.t but the problem is 
probably AT.

t/api/add_config.t creates a vhost. If I start httpd 
with "t/TEST -start-httpd" a new configuration is created in 
t/conf/apache_test_config.pm and the shows the correct vhost=&gt;port 
mapping:

  'TestAPI::add_config' =&gt; {
                            'hostport' =&gt; 'localhost:8567',
                            ...

httpd runs and I can connect to localhost:8567 and run the test via 
curl.

Now, if I try to run the test via "t/TEST -verbose -run-tests 
t/api/add_config.t" it tries to connect to a completely different port:

# connecting to http://localhost:8607/TestAPI__add_config/

The point is, t/TEST overwrites t/conf/apache_test_config.pm or rather 
reconfigures the system. But now the default ports at 8529 upwards are 
in use. So, it assigns new ones. This must be prevented in 
the -run-tests case. I think the whole reconfig thing should be skipped 
with -run-tests.

Does anyone know where to lay hands on or do I have to figure it out 
myself?

Torsten

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Apache2::HookRun question</title>
<author><name>Thomas Lindgren &lt;thomas.lindgren@diino.net&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200908.mbox/%3cb19048e50908190159u243521cdk38a1a3dd9356a35d@mail.gmail.com%3e"/>
<id>urn:uuid:%3cb19048e50908190159u243521cdk38a1a3dd9356a35d@mail-gmail-com%3e</id>
<updated>2009-08-19T08:59:07Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
Hi all,

I was directed here after asking around regarding the following. I hope this
is the right place.

I'm trying to use Apache2::HookRun according to the example provided in
http://perl.apache.org/docs/2.0/api/Apache2/HookRun.html

Two problems so far:

   1. Apache2::RequestRec doesn't appear to provide a new() method, so the
   example fails.
   2. A subsequent "$r-&gt;location_merge($path);" seems, according to the
   comments, to be required or bad things will happen -- but $path isn't
   declared or defined, and location_merge() seems not to be a method for
   Apache2::RequestRec either.

Okay, so the example code seems a bit broken. Does anyone know how it should
be fixed/rewritten? Thanks.

(In the greater scheme of things, I'm trying to get mod_perl to dryrun the
authn/authz phases with config, handlers, .htaccess and all, and provide the
results "as a service". HookRun seemed like an ideal way to implement that,
but if there are better ways of getting there, I'd also appreciate any
pointers.)

Best,
Thomas


</pre>
</div>
</content>
</entry>
<entry>
<title>IRC hacking this weekend</title>
<author><name>Fred Moyer &lt;fred@redhotpenguin.com&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200908.mbox/%3cad28918e0908141747u6b51958cg519fb8788624b79f@mail.gmail.com%3e"/>
<id>urn:uuid:%3cad28918e0908141747u6b51958cg519fb8788624b79f@mail-gmail-com%3e</id>
<updated>2009-08-15T00:47:51Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
I'm going to be on IRC this weekend, #modperl on irc.perl.org.  Let's
get 2.0.5 under way!

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Re: Proposal for CPAN module: Apache2::RequestRec::Time</title>
<author><name>Jan Pazdziora &lt;jpz-mlmp@adelton.com&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200908.mbox/%3c20090814161929.GB22513@relay.adelton.com%3e"/>
<id>urn:uuid:%3c20090814161929-GB22513@relay-adelton-com%3e</id>
<updated>2009-08-14T16:19:29Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
On Thu, Aug 13, 2009 at 12:46:50PM -0700, Fred Moyer wrote:
&gt; On Thu, Aug 13, 2009 at 12:21 PM, Jan Pazdziora&lt;jpz-mlmp@adelton.com&gt; wrote:
&gt; &gt; related to my previous post about getting to microsecond values
&gt; &gt; from APR/mod_perl, I propose to submit to CPAN a module
&gt; &gt; Apache2::RequestRec::Time which will add four functions (methods)
&gt; &gt; to Apache2::RequestRec: request_time_hires, request_duration,
&gt; &gt; request_duration_microseconds, and request_duration_hires.
&gt; 
&gt; I can't speak for the whole dev team, but I don't see any reason
&gt; offhand why these methods couldn't be included in the core since they
&gt; are RequestRec based.  This code is based off of the C api so it makes
&gt; a bit more sense to me to have it in core than as an external module.

Having it in core mod_perl is definitelly also an option. 

That however will not bring the functionality to already-released 
mod_perl 2 versions around the world. So my idea was to release this 
module on CPAN and if it gets to mod_perl core eventually, even 
better.

-- 
Jan Pazdziora

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Re: Proposal for CPAN module: Apache2::RequestRec::Time</title>
<author><name>Fred Moyer &lt;fred@redhotpenguin.com&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200908.mbox/%3cad28918e0908131246r15bfa288te4b71905ee220a3f@mail.gmail.com%3e"/>
<id>urn:uuid:%3cad28918e0908131246r15bfa288te4b71905ee220a3f@mail-gmail-com%3e</id>
<updated>2009-08-13T19:46:50Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>
On Thu, Aug 13, 2009 at 12:21 PM, Jan Pazdziora&lt;jpz-mlmp@adelton.com&gt; wrote:
&gt; related to my previous post about getting to microsecond values
&gt; from APR/mod_perl, I propose to submit to CPAN a module
&gt; Apache2::RequestRec::Time which will add four functions (methods)
&gt; to Apache2::RequestRec: request_time_hires, request_duration,
&gt; request_duration_microseconds, and request_duration_hires.

I can't speak for the whole dev team, but I don't see any reason
offhand why these methods couldn't be included in the core since they
are RequestRec based.  This code is based off of the C api so it makes
a bit more sense to me to have it in core than as an external module.

&gt;From my limited understanding of the mod_perl XS api this looks like
great start!

&gt;
&gt; My main goal is to be able to get value equivalent to custom
&gt; log's %D (time taken to serve the request, in microseconds) from
&gt; mod_perl, which request_duration_microseconds will do, and I wanted
&gt; the set of methods to be a big more complete in case people wanted
&gt; similar yet not exact functionality. Initially, I also planned to
&gt; have request_time_microseconds but I hit integer overflows as epoch
&gt; in microseconds is fairly big number.
&gt;
&gt; I'd appreciate any comments about suitability of such module and/or
&gt; its name, purpose, or implementation (for code, see below) before
&gt; I do the CPAN submission. Of course, the CPAN distribution will be
&gt; complete with Makefile.PL and test.
&gt;
&gt; Thank you.
&gt;
&gt; For the reference, my planned XS code is:
&gt;
&gt; #include &lt;mod_perl.h&gt;
&gt;
&gt; typedef request_rec *Apache2__RequestRec;
&gt;
&gt; MODULE = Apache2::RequestRec::Time      PACKAGE = Apache2::RequestRec   PREFIX = mpxs_Apache2__RequestRec_
&gt;
&gt; double
&gt; mpxs_Apache2__RequestRec_request_time_hires(r)
&gt;                Apache2::RequestRec r
&gt;        CODE:
&gt;                RETVAL = (double)(r-&gt;request_time) / APR_USEC_PER_SEC;
&gt;        OUTPUT:
&gt;                RETVAL
&gt;
&gt; long
&gt; mpxs_Apache2__RequestRec_request_duration(r)
&gt;                Apache2::RequestRec r
&gt;        CODE:
&gt;                apr_time_t duration = apr_time_now() - r-&gt;request_time;
&gt;                RETVAL = apr_time_sec(duration);
&gt;        OUTPUT:
&gt;                RETVAL
&gt;
&gt; double
&gt; mpxs_Apache2__RequestRec_request_duration_microseconds(r)
&gt;                Apache2::RequestRec r
&gt;        CODE:
&gt;                RETVAL = (double)(apr_time_now() - r-&gt;request_time);
&gt;        OUTPUT:
&gt;                RETVAL
&gt;
&gt; double
&gt; mpxs_Apache2__RequestRec_request_duration_hires(r)
&gt;                Apache2::RequestRec r
&gt;        CODE:
&gt;                RETVAL = (double)(apr_time_now() - r-&gt;request_time) / APR_USEC_PER_SEC;
&gt;        OUTPUT:
&gt;                RETVAL
&gt;
&gt; --
&gt; Jan Pazdziora
&gt;
&gt; ---------------------------------------------------------------------
&gt; To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
&gt; For additional commands, e-mail: dev-help@perl.apache.org
&gt;
&gt;

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
<entry>
<title>Proposal for CPAN module: Apache2::RequestRec::Time</title>
<author><name>Jan Pazdziora &lt;jpz-mlmp@adelton.com&gt;</name></author>
<link rel="alternate" href="http://mail-archives.apache.org/mod_mbox/perl-dev/200908.mbox/%3c20090813192152.GA21648@relay.adelton.com%3e"/>
<id>urn:uuid:%3c20090813192152-GA21648@relay-adelton-com%3e</id>
<updated>2009-08-13T19:21:52Z</updated>
<content type="xhtml">
<div xmlns="http://www.w3.org/1999/xhtml">
<pre>

Hello,

related to my previous post about getting to microsecond values
from APR/mod_perl, I propose to submit to CPAN a module
Apache2::RequestRec::Time which will add four functions (methods)
to Apache2::RequestRec: request_time_hires, request_duration,
request_duration_microseconds, and request_duration_hires.

My main goal is to be able to get value equivalent to custom
log's %D (time taken to serve the request, in microseconds) from
mod_perl, which request_duration_microseconds will do, and I wanted
the set of methods to be a big more complete in case people wanted
similar yet not exact functionality. Initially, I also planned to
have request_time_microseconds but I hit integer overflows as epoch
in microseconds is fairly big number.

I'd appreciate any comments about suitability of such module and/or
its name, purpose, or implementation (for code, see below) before
I do the CPAN submission. Of course, the CPAN distribution will be
complete with Makefile.PL and test.

Thank you.

For the reference, my planned XS code is:

#include &lt;mod_perl.h&gt;

typedef request_rec *Apache2__RequestRec;

MODULE = Apache2::RequestRec::Time      PACKAGE = Apache2::RequestRec   PREFIX = mpxs_Apache2__RequestRec_

double
mpxs_Apache2__RequestRec_request_time_hires(r)
                Apache2::RequestRec r
        CODE:
                RETVAL = (double)(r-&gt;request_time) / APR_USEC_PER_SEC;
        OUTPUT:
                RETVAL

long
mpxs_Apache2__RequestRec_request_duration(r)
                Apache2::RequestRec r
        CODE:
                apr_time_t duration = apr_time_now() - r-&gt;request_time;
                RETVAL = apr_time_sec(duration);
        OUTPUT:
                RETVAL

double
mpxs_Apache2__RequestRec_request_duration_microseconds(r)
                Apache2::RequestRec r
        CODE:
                RETVAL = (double)(apr_time_now() - r-&gt;request_time);
        OUTPUT:
                RETVAL

double
mpxs_Apache2__RequestRec_request_duration_hires(r)
                Apache2::RequestRec r
        CODE:
                RETVAL = (double)(apr_time_now() - r-&gt;request_time) / APR_USEC_PER_SEC;
        OUTPUT:
                RETVAL

-- 
Jan Pazdziora

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org



</pre>
</div>
</content>
</entry>
</feed>
